Skip to content

[WIP] feat: add eol page #7990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

[WIP] feat: add eol page #7990

wants to merge 18 commits into from

Conversation

bmuenzenmeyer
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer commented Jul 16, 2025

Description

Validation

EOL Page

image

EOL / Vulnerability Table

image

Link updated here

image

and here

image

Vulnerability Blog Posts

image

Related Issues

closes #7906

Check List

  • All other links on all alert boxes across the website (blog post from Matteo, Download pages, Version modal, etc) go to the /EOL page - did not do Matteo's blog post yet - would rather someone else choose to editorialize that.
  • should /eol be in the nav? I did not include it anywhere currently
  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copy link

vercel bot commented Jul 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 19, 2025 4:37pm

@bmuenzenmeyer
Copy link
Collaborator Author

ran with HUSKY=0 - eslint failures on git commit on Windows. investigating

Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.07%. Comparing base (77f675c) to head (5d2b82f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7990      +/-   ##
==========================================
- Coverage   73.13%   73.07%   -0.06%     
==========================================
  Files          95       95              
  Lines        8354     8354              
  Branches      218      219       +1     
==========================================
- Hits         6110     6105       -5     
- Misses       2243     2248       +5     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovflowd
Copy link
Member

ovflowd commented Jul 17, 2025

I feel this page should use a layout without the sidebar/metabar FYI

@bmuenzenmeyer
Copy link
Collaborator Author

bmuenzenmeyer commented Jul 17, 2025

I feel this page should use a layout without the sidebar/metabar FYI

that's fine - i just grabbed one quick - using page the default, does not render correctly (should open an issue for that. so using article for now)

this is page/default (not used anywhere)

image

this is the current pattern to expose translations to MDX, from what i can tell
@ovflowd
Copy link
Member

ovflowd commented Jul 19, 2025

@avivkeller can we use the new website for CVEs? https://www.cve.org/CVERecord?id=CVE-2025-23166 instead of cve.mitre.org?

@ovflowd
Copy link
Member

ovflowd commented Jul 19, 2025

Also this description:

"There are 4+ known vulnerabilities associated with this Node.js release. Please review their severity and details to understand the potential impact." not sure if it is fitting. I think we should lean more into what CVEs are how to understand them what having these issues are... IDK; Throwing the "Please review their severity and details to understand the potential impact." to the end-user might not be ideal. I mean in the end that's whaty they're going to do anyways, but we could use such section to explain actual concrete details of what CVEs means, what clicking these links means, idk.

@ovflowd
Copy link
Member

ovflowd commented Jul 19, 2025

Also can the "is EoL" be "has reached EOL" or "is EOL" or just "is vulnerable"

@ovflowd

This comment was marked as resolved.

@ovflowd
Copy link
Member

ovflowd commented Jul 19, 2025

I think the lists that only have unknown CVEs can render the pill of unknown:

image

@ovflowd

This comment was marked as resolved.

@bmuenzenmeyer
Copy link
Collaborator Author

bmuenzenmeyer commented Jul 19, 2025

I think the lists that only have unknown CVEs can render the pill of unknown

I am hoping we can resolve most of the unknowns actually, via nodejs/security-wg#1501

@ovflowd
Copy link
Member

ovflowd commented Jul 19, 2025

I think the lists that only have unknown CVEs can render the pill of unknown

I am hoping we can resolve most of the unknowns actually, via nodejs/security-wg#1501

Right, but let's focus on the now and not promises of the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dedicated EOL page
3 participants