Windows MSI installer creates doc shortcut with wrong URL

[vsemozhetbyt]

Meaning this shortcut in Start menu:

For example, in this build:

https://nodejs.org/download/v8-canary/v10.0.0-v8-canary20180306870146ff63/

Proper URL: https://nodejs.org/download/v8-canary/v10.0.0-v8-canary20180306870146ff63/docs/api/

Shortcut URL: https://nodejs.org/download/custom/v10.0.0-v8-canary20180306870146ff63/docs/api/ (404)

[targos]

@nodejs/build

[piccoloaiutante]

After a quick look it seems that that portion of URL is driven by DistTypeDir:

https://github.com/nodejs/node-v8/blob/canary/tools/msvs/msi/product.wxs#L261

And that variable is set into build.bat from server:

node-v8/vcbuild.bat

Line 344 in fecbce4

msbuild "%~dp0tools\msvs\msi\nodemsi.sln" /m /t:Clean,Build %msbsdk% /p:PlatformToolset=%PLATFORM_TOOLSET% /p:GypMsvsVersion=%GYP_MSVS_VERSION% /p:Configuration=%config% /p:Platform=%target_arch% /p:NodeVersion=%NODE_VERSION% /p:FullVersion=%FULLVERSION% /p:DistTypeDir=%DISTTYPEDIR% %noetw_msi_arg% %noperfctr_msi_arg% /clp:NoSummary;NoItemAndPropertyList;Verbosity=minimal /nologo

I guess it will be a matter to to set it properly into jenkins, isn't it @gibfahn ?

[gibfahn]

I guess it will be a matter to to set it properly into jenkins, isn't it @gibfahn ?

DistTypeDir is set in the ci-release job from DISTTYPE, which is a parameter in the job:

It should be release for regular releases.

[joaocgreis]

DISTTYPE and DISTTYPEDIR are changed to custom by the build script when building v8-canaries (and others). The correct variable to use should be RELEASE_URLBASE.

[targos]

So what needs to be changed to fix this?

[targos]

Is it still an issue?

[vsemozhetbyt]

For the last Canary build for Windows (as of 2019-01-02), yes, the issue still exists.