test: add type tags to uses of v8::External

Author: gahaas

test/addons/async-resource/binding.cc

@@ -39,20 +39,22 @@ void CreateAsyncResource(const FunctionCallbackInfo<Value>& args) {
     r = new AsyncResource(isolate, args[0].As<Object>(), "foobär");
   }
 
-  args.GetReturnValue().Set(
-      External::New(isolate, static_cast<void*>(r)));
+  args.GetReturnValue().Set(External::New(
+      isolate, static_cast<void*>(r), v8::kExternalPointerTypeTagDefault));
 }
 
 void DestroyAsyncResource(const FunctionCallbackInfo<Value>& args) {
   assert(args[0]->IsExternal());
-  auto r = static_cast<AsyncResource*>(args[0].As<External>()->Value());
+  auto r = static_cast<AsyncResource*>(
+      args[0].As<External>()->Value(v8::kExternalPointerTypeTagDefault));
   delete r;
 }
 
 void CallViaFunction(const FunctionCallbackInfo<Value>& args) {
   Isolate* isolate = args.GetIsolate();
   assert(args[0]->IsExternal());
-  auto r = static_cast<AsyncResource*>(args[0].As<External>()->Value());
+  auto r = static_cast<AsyncResource*>(
+      args[0].As<External>()->Value(v8::kExternalPointerTypeTagDefault));
 
   Local<String> name =
       String::NewFromUtf8(isolate, "methöd").ToLocalChecked();
@@ -69,7 +71,8 @@ void CallViaFunction(const FunctionCallbackInfo<Value>& args) {
 void CallViaString(const FunctionCallbackInfo<Value>& args) {
   Isolate* isolate = args.GetIsolate();
   assert(args[0]->IsExternal());
-  auto r = static_cast<AsyncResource*>(args[0].As<External>()->Value());
+  auto r = static_cast<AsyncResource*>(
+      args[0].As<External>()->Value(v8::kExternalPointerTypeTagDefault));
 
   Local<String> name =
       String::NewFromUtf8(isolate, "methöd").ToLocalChecked();
@@ -82,7 +85,8 @@ void CallViaString(const FunctionCallbackInfo<Value>& args) {
 void CallViaUtf8Name(const FunctionCallbackInfo<Value>& args) {
   Isolate* isolate = args.GetIsolate();
   assert(args[0]->IsExternal());
-  auto r = static_cast<AsyncResource*>(args[0].As<External>()->Value());
+  auto r = static_cast<AsyncResource*>(
+      args[0].As<External>()->Value(v8::kExternalPointerTypeTagDefault));
 
   Local<Value> arg = Integer::New(isolate, 42);
   MaybeLocal<Value> ret = r->MakeCallback("methöd", 1, &arg);
@@ -91,19 +95,22 @@ void CallViaUtf8Name(const FunctionCallbackInfo<Value>& args) {
 
 void GetAsyncId(const FunctionCallbackInfo<Value>& args) {
   assert(args[0]->IsExternal());
-  auto r = static_cast<AsyncResource*>(args[0].As<External>()->Value());
+  auto r = static_cast<AsyncResource*>(
+      args[0].As<External>()->Value(v8::kExternalPointerTypeTagDefault));
   args.GetReturnValue().Set(r->get_async_id());
 }
 
 void GetTriggerAsyncId(const FunctionCallbackInfo<Value>& args) {
   assert(args[0]->IsExternal());
-  auto r = static_cast<AsyncResource*>(args[0].As<External>()->Value());
+  auto r = static_cast<AsyncResource*>(
+      args[0].As<External>()->Value(v8::kExternalPointerTypeTagDefault));
   args.GetReturnValue().Set(r->get_trigger_async_id());
 }
 
 void GetResource(const FunctionCallbackInfo<Value>& args) {
   assert(args[0]->IsExternal());
-  auto r = static_cast<AsyncResource*>(args[0].As<External>()->Value());
+  auto r = static_cast<AsyncResource*>(
+      args[0].As<External>()->Value(v8::kExternalPointerTypeTagDefault));
   args.GetReturnValue().Set(r->get_resource());
 }