Khesim/ibm system update (#86)

* Added qasm simulator as default quantum backend.

* Corrected error message for large circuits.

* Updating ibm system node defaults.

* Fixed default settings for running on IBM Quantum

* Fixed qasm simulator overriding preferred system.

* Refactor redundant code.

* Restructure if/else statement.

* Shot min & default value set to 1

* Typo resulting in IBM Quantum QASM bug

* redundant error handling

* Removed tag icon in front of node property input fields

* New node properties HTML interface

Co-authored-by: Theo Reignier <[email protected]>

Author: KhesimReid

quantum/nodes/ibm-quantum-system/ibm-quantum-system.html

@@ -5,7 +5,19 @@
     defaults: {
       name: { value: "" },
       api_token: { value: "", required: true },
+      chosen_system: { value: "" },
       preferred_backend: { value: "" },
+      shots: { 
+        value: 1, 
+        validate: function (x) {
+          x = parseInt(x);
+          if (Number.isInteger(x) && x > 0) {
+            return true;
+          } else {
+            return false;
+          }
+        },
+      },
       preferred_output: { value: "" },
     },
     inputs: 1,
@@ -15,7 +27,7 @@
     label: function () {
       return this.name || "ibm quantum system";
     },
-  });
+  })
 </script>
 
 <script type="text/html" data-template-name="ibm-quantum-system">
@@ -32,23 +44,35 @@
     <input type="text" id="node-input-api_token" placeholder="API Token" style="margin-bottom: 20px;"/>
   </div>
 
-  <div class="form-row">
-    <label for="node-input-preferred_backend" id="user-backend"
-      >Quantum Backend
-    </label>
+  <div style="width:40%; text-align:center; float:left; margin-bottom: 40px;">
+    <label for="node-input-chosen_system">Least Busy Backend</label>
+    <select name="chosen_system" id="node-input-chosen_system" style="width:85%">
+      <option value="Simulator">Simulator</option>
+      <option value="Qubit_System">Quantum System</option>
+    </select>
+  </div>
+  <div style="width:5%; font-size:10pt; text-align:center; float:left; margin-top: 20px;">OR</div>
+  <div style="width:40%; text-align:center; float:left; margin-bottom: 40px;">
+    <label for="node-input-preferred_backend" id="user-backend">Specific Backend</label>
     <input
       type="text"
       id="node-input-preferred_backend"
       placeholder="Preferred Backend"
-      style="margin-bottom: 20px;"
+      style="width:85%"
     />
   </div>
 
+  <div class="form-row">
+    <label for="node-input-shots">Shots</label>
+    <input type="number" min="1" id="node-input-shots" placeholder="1000"/>
+  </div>
+
   <div class="form-row">
     <label for="node-input-preferred_output">Output Format</label>
     <select name="preferred_output" id="node-input-preferred_output">
-      <option value="Verbose">Verbose</option>
       <option value="Results">Results Only</option>
+      <option value="Verbose">Verbose</option>
     </select>
   </div>
-</script>
+
+</script>

quantum/nodes/ibm-quantum-system/ibm-quantum-system.js

@@ -9,8 +9,10 @@ module.exports = function(RED) {
   function IBMQuantumSystemNode(config) {
     RED.nodes.createNode(this, config);
     this.apiToken = config.api_token;
+    this.chosenSystem = config.chosen_system;
     this.preferredBackend = config.preferred_backend;
     this.outputPreference = config.preferred_output;
+    this.shots = config.shots || 1;
     this.qubits = [];
     this.qreg = '';
     const node = this;
@@ -34,6 +36,7 @@ module.exports = function(RED) {
         return;
       }
 
+
       // If the quantum circuit does not have registers
       if (typeof(msg.payload.register) === 'undefined') {
         node.qreg = undefined;
@@ -108,13 +111,21 @@ module.exports = function(RED) {
         if (node.preferredBackend) {
           script += util.format(snippets.IBMQ_SYSTEM_PREFERRED, node.apiToken, node.preferredBackend);
         } else {
-          script += util.format(snippets.IBMQ_SYSTEM_DEFAULT, node.apiToken, node.qubits.length);
+          if (node.chosenSystem == 'Qubit_System') {
+            script += util.format(snippets.IBMQ_SYSTEM_DEFAULT, node.apiToken, node.qubits.length, 'False');
+          } else {
+            if (node.qubits.length > 32) {
+              script += util.format(snippets.IBMQ_SYSTEM_DEFAULT, node.apiToken, node.qubits.length, 'True');
+            } else {
+              script += util.format(snippets.IBMQ_SYSTEM_QASM, node.apiToken);
+            }
+          }
         }
 
         if (node.outputPreference == 'Verbose') {
-          script += snippets.IBMQ_SYSTEM_VERBOSE;
+          script += util.format(snippets.IBMQ_SYSTEM_VERBOSE, node.shots);
         } else {
-          script += snippets.IBMQ_SYSTEM_RESULT;
+          script += util.format(snippets.IBMQ_SYSTEM_RESULT, node.shots);
         }
 
         await shell.execute(script, (err, data) => {

quantum/nodes/local-simulator/local-simulator.html

@@ -24,7 +24,7 @@
     <input type="text" id="node-input-name" placeholder="Name" />
   </div>
   <div class="form-row">
-    <label for="node-input-shots"><i class="fa fa-tag"></i> Shots</label>
+    <label for="node-input-shots">Shots</label>
     <input type="number" id="node-input-shots" placeholder="1000"/>
   </div>
 </script>

quantum/snippets.js

@@ -56,10 +56,16 @@ counts = result.get_counts()
 print(counts)
 `;
 
+const IBMQ_SYSTEM_QASM =
+`from qiskit.providers.ibmq import least_busy
+provider = IBMQ.enable_account('%s')
+backend_service = provider.get_backend('ibmq_qasm_simulator')
+`;
+
 const IBMQ_SYSTEM_DEFAULT =
 `from qiskit.providers.ibmq import least_busy
 provider = IBMQ.enable_account('%s')
-backends = provider.backends(filters=lambda x: x.configuration().n_qubits >= %s)
+backends = provider.backends(filters=lambda x: (x.configuration().n_qubits >= %s and x.configuration().simulator == %s))
 backend_service = least_busy(backends)
 `;
 
@@ -69,12 +75,12 @@ backend_service = provider.get_backend('%s')
 `;
 
 const IBMQ_SYSTEM_VERBOSE =
-`job = execute(qc, backend=backend_service)
+`job = execute(qc, backend=backend_service, shots=%s)
 job.result()
 `;
 
 const IBMQ_SYSTEM_RESULT =
-`job = execute(qc, backend=backend_service)
+`job = execute(qc, backend=backend_service, shots=%s)
 counts = job.result().get_counts()
 print(counts)
 `;
@@ -167,6 +173,7 @@ module.exports = {
   MEASURE,
   LOCAL_SIMULATOR,
   MULTI_CONTROLLED_U_GATE,
+  IBMQ_SYSTEM_QASM,
   IBMQ_SYSTEM_DEFAULT,
   IBMQ_SYSTEM_PREFERRED,
   IBMQ_SYSTEM_VERBOSE,