Skip to content

Commit 795c36f

Browse files
committed
Drop support for versions lower than 6.6
1 parent 82211ae commit 795c36f

File tree

13 files changed

+14
-47
lines changed

13 files changed

+14
-47
lines changed

src/main/kotlin/com/github/gradle/node/NodePlugin.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,7 @@ class NodePlugin : Plugin<Project> {
122122
content {
123123
includeModule("org.nodejs", "node")
124124
}
125-
if (GradleVersion.current() >= GradleVersion.version("6.0")) {
126-
allowInsecureProtocol?.let { isAllowInsecureProtocol = it }
127-
}
125+
allowInsecureProtocol?.let { isAllowInsecureProtocol = it }
128126
}
129127
}
130128

src/main/kotlin/com/github/gradle/node/PackageJsonExtension.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@ open class PackageJsonExtension(project: Project) {
1717
val node = project.objects.property<JsonNode>()
1818

1919
init {
20-
if (GradleVersion.current() >= GradleVersion.version("6.1")) {
21-
node.finalizeValueOnRead()
22-
}
20+
node.finalizeValueOnRead()
2321
node.set(project.provider { project.file("package.json").let(ObjectMapper()::readTree) })
2422
}
2523

src/main/kotlin/com/github/gradle/node/util/ProjectApiHelper.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import org.gradle.util.GradleVersion
1414
import java.io.File
1515
import javax.inject.Inject
1616

17+
@Deprecated(message = "Only 6.6 and newer is supported")
1718
interface ProjectApiHelper {
1819
companion object {
1920
@JvmStatic
@@ -26,7 +27,7 @@ interface ProjectApiHelper {
2627
}
2728

2829
private fun enableConfigurationCache(): Boolean {
29-
return GradleVersion.current() >= GradleVersion.version("6.6")
30+
return true
3031
}
3132
}
3233

src/test/resources/fixtures/node-env/build.gradle

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,5 @@ task version(type: NodeTask) {
5858
}
5959

6060
def isPropertyEnabled(String name) {
61-
if (GradleVersion.current() >= GradleVersion.version("6.6")) {
62-
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
63-
}
64-
return System.properties[name] != null
61+
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
6562
}

src/test/resources/fixtures/node/build.gradle

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,5 @@ task version(type: NodeTask) {
4343
}
4444

4545
def isPropertyEnabled(String name) {
46-
if (GradleVersion.current() >= GradleVersion.version("6.6")) {
47-
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
48-
}
49-
return System.properties[name] != null
46+
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
5047
}

src/test/resources/fixtures/npm-env/build.gradle

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,5 @@ if (isPropertyEnabled("outputFile")) {
6060
}
6161

6262
def isPropertyEnabled(String name) {
63-
if (GradleVersion.current() >= GradleVersion.version("6.6")) {
64-
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
65-
}
66-
return System.properties[name] != null
63+
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
6764
}

src/test/resources/fixtures/npm/build.gradle

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,5 @@ task version(type: NpmTask) {
3030
}
3131

3232
def isPropertyEnabled(String name) {
33-
if (GradleVersion.current() >= GradleVersion.version("6.6")) {
34-
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
35-
}
36-
return System.properties[name] != null
33+
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
3734
}

src/test/resources/fixtures/npx-env/build.gradle

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,5 @@ if (isPropertyEnabled("outputFile")) {
6969
}
7070

7171
def isPropertyEnabled(String name) {
72-
if (GradleVersion.current() >= GradleVersion.version("6.6")) {
73-
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
74-
}
75-
return System.properties[name] != null
72+
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
7673
}

src/test/resources/fixtures/npx/build.gradle

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,5 @@ if (isPropertyEnabled("changeInputs")) {
6060
}
6161

6262
def isPropertyEnabled(String name) {
63-
if (GradleVersion.current() >= GradleVersion.version("6.6")) {
64-
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
65-
}
66-
return System.properties[name] != null
63+
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
6764
}

src/test/resources/fixtures/pnpm-env/build.gradle

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,5 @@ if (isPropertyEnabled("outputFile")) {
5959
}
6060

6161
def isPropertyEnabled(String name) {
62-
if (GradleVersion.current() >= GradleVersion.version("6.6")) {
63-
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
64-
}
65-
return System.properties[name] != null
62+
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
6663
}

src/test/resources/fixtures/pnpm/build.gradle

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,5 @@ task version(type: PnpmTask) {
3030
}
3131

3232
def isPropertyEnabled(String name) {
33-
if (GradleVersion.current() >= GradleVersion.version("6.6")) {
34-
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
35-
}
36-
return System.properties[name] != null
33+
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
3734
}

src/test/resources/fixtures/yarn-env/build.gradle

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,5 @@ if (isPropertyEnabled("outputFile")) {
6060
}
6161

6262
def isPropertyEnabled(String name) {
63-
if (GradleVersion.current() >= GradleVersion.version("6.6")) {
64-
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
65-
}
66-
return System.properties[name] != null
63+
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
6764
}

src/test/resources/fixtures/yarn/build.gradle

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,5 @@ task version(type: YarnTask) {
3131
}
3232

3333
def isPropertyEnabled(String name) {
34-
if (GradleVersion.current() >= GradleVersion.version("6.6")) {
35-
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
36-
}
37-
return System.properties[name] != null
34+
return providers.systemProperty(name).forUseAtConfigurationTime().isPresent()
3835
}

0 commit comments

Comments
 (0)