Skip to content

Missmatch of dependencies versions between NPM and github #1987

@meydanb

Description

@meydanb

Describe the bug
When going through the package.json file in the github repository, the following is present:
"dependencies": { "@vue/cli-shared-utils": "^5.0.5", "chokidar": "^3.0.2", "electron-builder": "^23.0.3", "execa": "^5.0.0", "friendly-errors-webpack-plugin": "^1.7.0", "fs-extra": "^10.0.0", "lodash.merge": "^4.6.1", "portfinder": "^1.0.16", "pumpify": "^2.0.1", "semver": "^7.3.2", "shebang-loader": "^0.0.1", "split2": "^4.1.0", "terser-webpack-plugin": "^4.2.3", "through2-filter": "^3.0.0", "through2-map": "^3.0.0", "unzip-crx": "^0.2.0", "webpack": "^4.33.0", "webpack-chain": "^6.0.0", "webpack-merge": "^4.2.2", "yargs": "^17.5.1" },

When looking at the same file in the npm repository:
"dependencies": { "@vue/cli-shared-utils": "^4.5.6", "chokidar": "^3.0.2", "electron-builder": "^22.2.0", "execa": "^5.0.0", "friendly-errors-webpack-plugin": "^1.7.0", "fs-extra": "^9.0.1", "lodash.merge": "^4.6.1", "portfinder": "^1.0.16", "pumpify": "^2.0.1", "semver": "^7.3.2", "shebang-loader": "^0.0.1", "split2": "^3.0.0", "terser-webpack-plugin": "^3.0.3", "through2-filter": "^3.0.0", "through2-map": "^3.0.0", "unzip-crx": "^0.2.0", "webpack": "^4.18.0", "webpack-chain": "^6.0.0", "webpack-merge": "^4.2.2", "yargs": "^15.3.1" },
even though it has the same version number 2.1.1 in both...

To Reproduce
No need

Expected behavior
To me it seems that the package.json files should be the same in the github repositry and in npm

Additional context
I found this issue when trying to build my app that uses this plugin, on an offline computer,
specifing the ELECTRON_MIRROR enviroment variable was able to download electron binaries but the winCodeSign failed to download becuase it was not using the mirror url,
after investigating this i saw a bug in electron-builder where this varialbe was not taking into account for the winCodeSign and nsis variables

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions