Skip to content
This repository was archived by the owner on Apr 1, 2024. It is now read-only.

Commit a2334de

Browse files
committed
Move channel into the subscription
Similar to ocm-ramen-sample PR[1] move the channel into the subscription kustomization. This is better for users, removing setup and teardown from the deployment steps. Now it is not possible to forget to deploy or remove the channel after testing. This is better for developers, since now we can test multiple VMs concurrently, without dealing with setup and cleanup of shared resources, since VMs do not share the channel. [1] RamenDR/ocm-ramen-samples#41
1 parent b493b45 commit a2334de

File tree

6 files changed

+3
-28
lines changed

6 files changed

+3
-28
lines changed

README.md

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,6 @@ the included SSH public key with your own public key.
4545
1. If you are not using the `main` branch update
4646
`subscription/subscription.yaml` to point to the right branch.
4747

48-
### Deploying the channel
49-
50-
Deploy the channel to introduce this repo to *OCM*:
51-
52-
```sh
53-
kubectl apply -k channel --context hub
54-
```
55-
5648
### Deploying the VM subscription
5749

5850
To start the VM deploy the subscription:
@@ -408,11 +400,3 @@ Delete the subscription to stop and delete the VM:
408400
```sh
409401
kubectl delete -k subscription --context hub
410402
```
411-
412-
### Delete the channel
413-
414-
When done you can delete the channel:
415-
416-
```sh
417-
kubectl delete -k channel --context hub
418-
```

channel/kustomization.yaml

Lines changed: 0 additions & 5 deletions
This file was deleted.

channel/namespace.yaml

Lines changed: 0 additions & 5 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
apiVersion: apps.open-cluster-management.io/v1
33
kind: Channel
44
metadata:
5-
name: kubevirt-gitops
5+
name: ocm-kubevirt-samples
66
spec:
77
type: GitHub
88
pathname: https://github.com/aglitke/ocm-kubevirt-samples.git

subscription/kustomization.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
---
22
resources:
33
- namespace.yaml
4+
- channel.yaml
45
- binding.yaml
56
- placement.yaml
67
- subscription.yaml

subscription/subscription.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ metadata:
77
apps.open-cluster-management.io/github-path: vm-standalone-pvc-k8s
88
name: kubevirt-sub
99
spec:
10-
channel: kubevirt-samples/kubevirt-gitops
10+
channel: kubevirt-sample/ocm-kubevirt-samples
1111
placement:
1212
placementRef:
1313
kind: Placement

0 commit comments

Comments
 (0)