Mil unit is off by a factor of 1,000,000 #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

PeterJohnson opened this issue May 1, 2025 · 0 comments

PeterJohnson commented May 1, 2025 •

edited

Loading

units/include/units.h

Line 3401 in 7c90daf

UNIT_ADD(length, mil, mils, mil, unit<std::ratio<1000>, inches>)

currently defines mil as 1000 inches, when it should be 1/1000 of an inch.

A change was attempted in response to #241 but it wasn't correct.

A fix was merged to the 3.x branch in #321 but not backported to master.

Discovered in wpilibsuite/allwpilib#7950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment