Skip to content

Commit d32d107

Browse files
authored
chore: update golang versions (#308)
Fix a broken build by upgrading to the latest golang version. Also updated `gomarkdown` to resolve some low-priority security notices and `golangci-lint` to keep up with the golang version. The build broke because we're using "latest" versions of some dev libraries. I considered pinning those instead of upgrading golang, but "latest" fails infrequently, and we're already two minor versions behind on golang so needed to update anyway. If we have a similar failure will switch to a `tools.go` approach and manage tool versions in go.mod with the rest of the dependencies. fixes #307
1 parent b33676b commit d32d107

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

reference-converter/go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
module github.com/nginxinc/nginx-directive-reference/reference-converter
22

3-
go 1.21
3+
go 1.23
44

55
require (
6-
github.com/gomarkdown/markdown v0.0.0-20230716120725-531d2d74bc12
6+
github.com/gomarkdown/markdown v0.0.0-20241205020045-f7e15b2f3e62
77
github.com/stretchr/testify v1.10.0
88
)
99

reference-converter/go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
22
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
3-
github.com/gomarkdown/markdown v0.0.0-20230716120725-531d2d74bc12 h1:uK3X/2mt4tbSGoHvbLBHUny7CKiuwUip3MArtukol4E=
4-
github.com/gomarkdown/markdown v0.0.0-20230716120725-531d2d74bc12/go.mod h1:JDGcbDT52eL4fju3sZ4TeHGsQwhG9nbDV21aMyhwPoA=
3+
github.com/gomarkdown/markdown v0.0.0-20241205020045-f7e15b2f3e62 h1:pbAFUZisjG4s6sxvRJvf2N7vhpCvx2Oxb3PmS6pDO1g=
4+
github.com/gomarkdown/markdown v0.0.0-20241205020045-f7e15b2f3e62/go.mod h1:JDGcbDT52eL4fju3sZ4TeHGsQwhG9nbDV21aMyhwPoA=
55
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
66
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
77
github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOfJA=

tools/devtools/Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
ARG GO_VERSION=1.21
1+
ARG GO_VERSION=1.23
22
ARG NODE_VERSION=18
33
ARG BASE_IMG=docker.io/library/node:${NODE_VERSION}-bullseye
44

5-
FROM docker.io/library/golang:${GO_VERSION}-bullseye as golang
5+
FROM docker.io/library/golang:${GO_VERSION}-bullseye AS golang
66
ARG GO_JUNIT_REPORT_VERSION=latest
77
ARG GOPLS_VERSION=latest
88
ARG DELVE_VERSION=latest
9-
ARG GOLANGCI_LINT_VERSION=1.54.1
9+
ARG GOLANGCI_LINT_VERSION=1.62.2
1010

1111
RUN go install github.com/jstemmer/go-junit-report/v2@${GO_JUNIT_REPORT_VERSION} \
1212
&& go install -v golang.org/x/tools/gopls@${GOPLS_VERSION} \

0 commit comments

Comments
 (0)