Skip to content

Commit 137be85

Browse files
committed
Refactor CI workflow
Should work with newest versions?
1 parent f60113c commit 137be85

File tree

4 files changed

+18
-50
lines changed

4 files changed

+18
-50
lines changed

.github/workflows/ci.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,7 @@ jobs:
2121
node-version: ${{ matrix.node-version }}
2222
cache: 'npm'
2323
- run: npm install
24-
- name: 'Setup tests'
25-
run: bash test/setup.sh
26-
- name: 'Run basic tests'
27-
run: bash test/run.sh
24+
- run: npm test
2825

2926
integration:
3027
runs-on: ubuntu-latest
@@ -38,8 +35,15 @@ jobs:
3835
- run: npm install
3936
- name: 'Setup dist'
4037
run: bash test/setup.sh --dist
41-
- name: 'Run complete test suite'
42-
run: bash test/run.sh --dist
38+
- name: Run coverage
39+
run: |
40+
npm run build
41+
npm run test:coverage
42+
- name: Run browser tests
43+
if: ${{ github.secret_source == 'Actions' }}
44+
run: |
45+
npm run copy
46+
npm run test:ci
4347
env:
4448
BROWSERSTACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }}
4549
BROWSERSTACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }}

test/run.sh

Lines changed: 0 additions & 20 deletions
This file was deleted.

test/setup.sh

Lines changed: 0 additions & 16 deletions
This file was deleted.

test/spec/linkify-react.test.mjs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from 'react';
2-
import ReactDOMServer from 'react-dom/server';
2+
import { renderToStaticMarkup } from 'react-dom/server';
33
import * as linkify from 'linkifyjs';
44
import Linkify from 'linkify-react/src/linkify-react.mjs';
55
import mention from 'linkify-plugin-mention/src/mention.mjs';
@@ -53,7 +53,7 @@ describe('linkify-react', () => {
5353
it('Works with default options', function () {
5454
tests.map((test) => {
5555
var linkified = React.createElement(Linkify, null, test[0]);
56-
var result = ReactDOMServer.renderToStaticMarkup(linkified);
56+
var result = renderToStaticMarkup(linkified);
5757
expect(result).to.be.oneOf([test[1], `<span>${test[1]}</span>`]);
5858
});
5959
});
@@ -62,15 +62,15 @@ describe('linkify-react', () => {
6262
tests.map((test) => {
6363
var props = { options, as: 'div', className: 'lambda' };
6464
var linkified = React.createElement(Linkify, props, test[0]);
65-
var result = ReactDOMServer.renderToStaticMarkup(linkified);
65+
var result = renderToStaticMarkup(linkified);
6666
expect(result).to.be.eql(test[2]);
6767
});
6868
});
6969

7070
it('Finds links recursively', function () {
7171
var strong = React.createElement('strong', null, 'https://facebook.github.io/react/');
7272
var linkified = React.createElement(Linkify, null, 'A great site is google.com AND ', strong);
73-
var result = ReactDOMServer.renderToStaticMarkup(linkified);
73+
var result = renderToStaticMarkup(linkified);
7474
var expected =
7575
'A great site is <a href="http://google.com">google.com</a> AND <strong><a href="https://facebook.github.io/react/">https://facebook.github.io/react/</a></strong>';
7676
expect(result).to.be.oneOf([expected, `<span>${expected}</span>`]);
@@ -85,7 +85,7 @@ describe('linkify-react', () => {
8585

8686
var delta = React.createElement(Delta);
8787
var linkified = React.createElement(Linkify, null, 'A great site is google.com AND ', delta);
88-
var result = ReactDOMServer.renderToStaticMarkup(linkified);
88+
var result = renderToStaticMarkup(linkified);
8989
var expected =
9090
'A great site is <a href="http://google.com">google.com</a> AND <strong>https://facebook.github.io/react/</strong>';
9191
expect(result).to.be.oneOf([expected, `<span>${expected}</span>`]);
@@ -97,7 +97,7 @@ describe('linkify-react', () => {
9797
};
9898
var em = React.createElement('em', null, 'https://facebook.github.io/react/');
9999
var linkified = React.createElement(Linkify, { options }, 'A great site is google.com AND ', em);
100-
var result = ReactDOMServer.renderToStaticMarkup(linkified);
100+
var result = renderToStaticMarkup(linkified);
101101
var expected =
102102
'A great site is <a href="http://google.com">google.com</a> AND <em>https://facebook.github.io/react/</em>';
103103
expect(result).to.be.oneOf([expected, `<span>${expected}</span>`]);
@@ -121,7 +121,7 @@ describe('linkify-react', () => {
121121
'For the latest javascript.net\n',
122122
React.createElement('strong', { key: 1 }, ['and also\n', '🥺👄.ws']),
123123
);
124-
const result = ReactDOMServer.renderToStaticMarkup(linkified);
124+
const result = renderToStaticMarkup(linkified);
125125
const expected = [
126126
'hello<br/><br/>\t\t ',
127127
'hello<br/><br/>\t\t',
@@ -155,7 +155,7 @@ describe('linkify-react', () => {
155155
{ options },
156156
'Check out linkify.js.org or contact @nfrasser',
157157
);
158-
const result = ReactDOMServer.renderToStaticMarkup(linkified);
158+
const result = renderToStaticMarkup(linkified);
159159
const expected =
160160
'Check out <a href="http://linkify.js.org">linkify.js.org</a> or contact <span data-to="/users/nfrasser">@nfrasser</span>';
161161
expect(result).to.be.oneOf([expected, `<span>${expected}</span>`]);

0 commit comments

Comments
 (0)