Merge pull request #53047 from nextcloud/fix/recommended-apps

fix: recommended apps button test

Author: susnux

core/src/components/setup/RecommendedApps.vue

@@ -38,17 +38,16 @@
 
 		<div class="dialog-row">
 			<NcButton v-if="showInstallButton && !installingApps"
-				type="tertiary"
-				role="link"
+				data-cy-setup-recommended-apps-skip
 				:href="defaultPageUrl"
-				data-cy-setup-recommended-apps-skip>
+				variant="tertiary">
 				{{ t('core', 'Skip') }}
 			</NcButton>
 
 			<NcButton v-if="showInstallButton"
-				type="primary"
+				data-cy-setup-recommended-apps-install
 				:disabled="installingApps || !isAnyAppSelected"
-				data-cy-setup-recommended-apps-install>
+				variant="primary"
 				@click.stop.prevent="installApps">
 				{{ installingApps ? t('core', 'Installing apps …') : t('core', 'Install recommended apps') }}
 			</NcButton>

cypress/e2e/core/setup.ts

@@ -124,8 +124,19 @@ function sharedSetup() {
 	cy.location('pathname', { timeout: 10000 })
 		.should('include', '/core/apps/recommended')
 
+	// See the apps setup
+	cy.get('[data-cy-setup-recommended-apps]')
+		.should('be.visible')
+		.within(() => {
+			cy.findByRole('heading', { name: 'Recommended apps' })
+				.should('be.visible')
+			cy.findByRole('button', { name: 'Skip' })
+				.should('be.visible')
+			cy.findByRole('button', { name: 'Install recommended apps' })
+				.should('be.visible')
+		})
+
 	// Skip the setup apps
-	cy.get('[data-cy-setup-recommended-apps]').should('be.visible')
 	cy.get('[data-cy-setup-recommended-apps-skip]').click()
 
 	// Go to files