fix: add functions-internal directory if missing (#555)

* fix: create directory if does not exist

* chore: lint

* chore: lint

* chore: string fix

Author: sarahetter

plugin/src/helpers/functions.ts

@@ -85,6 +85,8 @@ export const setupImageCdn = async ({
     return
   }
 
+  await ensureDir(constants.INTERNAL_FUNCTIONS_SRC)
+
   await copyFile(
     join(__dirname, '..', '..', 'src', 'templates', 'ipx.ts'),
     join(constants.INTERNAL_FUNCTIONS_SRC, '_ipx.ts'),

plugin/test/unit/helpers/functions.spec.ts

@@ -0,0 +1,94 @@
+import { join } from 'path'
+import process from 'process'
+
+import Chance from 'chance'
+import { copy, existsSync } from 'fs-extra'
+import { dir as getTmpDir } from 'tmp-promise'
+
+import { setupImageCdn } from '../../../src/helpers/functions'
+
+const SAMPLE_PROJECT_DIR = `${__dirname}/../../../../demo`
+const TEST_TIMEOUT = 60_000
+
+const changeCwd = (cwd) => {
+  const originalCwd = process.cwd()
+  process.chdir(cwd)
+  return () => {
+    process.chdir(originalCwd)
+  }
+}
+
+// Move gatsby project from sample project to current directory
+const moveGatsbyDir = async () => {
+  await copy(SAMPLE_PROJECT_DIR, join(process.cwd()))
+}
+
+const chance = new Chance()
+
+describe('setupImageCdn', () => {
+  let cleanup
+  let restoreCwd
+
+  beforeEach(async () => {
+    const tmpDir = await getTmpDir({ unsafeCleanup: true })
+
+    restoreCwd = changeCwd(tmpDir.path)
+    // eslint-disable-next-line prefer-destructuring
+    cleanup = tmpDir.cleanup
+  })
+
+  afterEach(async () => {
+    // Cleans up the temporary directory from `getTmpDir()` and do not make it
+    // the current directory anymore
+    restoreCwd()
+    await cleanup()
+  }, TEST_TIMEOUT)
+  it(
+    'successfully creates a functions-internal directory if it does not exist',
+    async () => {
+      await moveGatsbyDir()
+      const constants = {
+        INTERNAL_FUNCTIONS_SRC: 'demo/.netlify/functions-internal',
+        PUBLISH_DIR: 'demo/public',
+        FUNCTIONS_DIST: 'demo/.netlify/functions',
+        EDGE_HANDLERS_DIST: 'demo/.netlify/edge-functions-dist/',
+        IS_LOCAL: true,
+        NETLIFY_BUILD_VERSION: '9000.0.0',
+        SITE_ID: chance.guid(),
+      }
+
+      const netlifyConfig = {
+        build: {
+          command: 'npm run build',
+          publish: 'demo/public',
+          base: '.',
+          environment: {
+            GATSBY_CLOUD_IMAGE_CDN: 'true',
+          },
+          services: {},
+          processing: {
+            css: {},
+            js: {},
+            html: {},
+            images: {},
+          },
+        },
+        functions: { '*': {} },
+        redirects: [],
+        headers: [],
+        edge_handlers: [],
+        plugins: [],
+      }
+
+      await setupImageCdn({ constants, netlifyConfig })
+
+      const doesDirectoryExist = existsSync(
+        join(process.cwd(), 'demo', '.netlify', 'functions-internal'),
+      )
+
+      expect(doesDirectoryExist).toEqual(true)
+      // Longer timeout for the test is necessary due to the copying of the demo project into the tmp dir
+    },
+    TEST_TIMEOUT,
+  )
+})