Fix missing error handling

mraerino · mraerino · commit bfd1e209768e · 2019-09-10T10:37:22.000+02:00
diff --git a/api/payments.go b/api/payments.go
@@ -224,7 +224,9 @@ func (a *API) PaymentCreate(w http.ResponseWriter, r *http.Request) error {
 	}
 
 	paymentComplete(r, tx, tr, order)
-	tx.Commit()
+	if err := tx.Commit().Error; err != nil {
+		return internalServerError("Saving payment failed").WithInternalError(err)
+	}
 
 	go sendOrderConfirmation(ctx, log, tr)
 

Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,9 @@ func (a API) PaymentCreate(w http.ResponseWriter, r http.Request) error {`
`224`	`224`	`}`
`225`	`225`
`226`	`226`	`paymentComplete(r, tx, tr, order)`
`227`		`- tx.Commit()`
	`227`	`+ if err := tx.Commit().Error; err != nil {`
	`228`	`+ return internalServerError("Saving payment failed").WithInternalError(err)`
	`229`	`+ }`
`228`	`230`
`229`	`231`	`go sendOrderConfirmation(ctx, log, tr)`
`230`	`232`