Skip to content

Commit b448bb2

Browse files
committed
Move error check into condition
1 parent b2178c7 commit b448bb2

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

api/payments.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -205,16 +205,16 @@ func (a *API) PaymentCreate(w http.ResponseWriter, r *http.Request) error {
205205
tr.InvoiceNumber = invoiceNumber
206206
order.PaymentProcessor = provider.Name()
207207

208-
if pendingErr, ok := err.(*payments.PaymentPendingError); ok {
209-
tr.Status = models.PendingState
210-
tr.ProviderMetadata = pendingErr.Metadata()
211-
tx.Create(tr)
212-
tx.Save(order)
213-
tx.Commit()
214-
return sendJSON(w, 200, tr)
215-
}
216-
217208
if err != nil {
209+
if pendingErr, ok := err.(*payments.PaymentPendingError); ok {
210+
tr.Status = models.PendingState
211+
tr.ProviderMetadata = pendingErr.Metadata()
212+
tx.Create(tr)
213+
tx.Save(order)
214+
tx.Commit()
215+
return sendJSON(w, 200, tr)
216+
}
217+
218218
tr.FailureCode = strconv.FormatInt(http.StatusInternalServerError, 10)
219219
tr.FailureDescription = err.Error()
220220
tr.Status = models.FailedState

0 commit comments

Comments
 (0)