Make confirm call idempotent

mraerino · mraerino · commit 0341b711c91d · 2019-09-09T12:22:11.000+02:00
diff --git a/api/payments.go b/api/payments.go
@@ -253,6 +253,10 @@ func (a *API) PaymentConfirm(w http.ResponseWriter, r *http.Request) error {
 		}
 	}
 
+	if trans.Status == models.PaidState {
+		return sendJSON(w, http.StatusOK, trans)
+	}
+
 	order := &models.Order{}
 	if rsp := a.db.Find(order, "id = ?", trans.OrderID); rsp.Error != nil {
 		if rsp.RecordNotFound() {

Original file line number	Diff line number	Diff line change
`@@ -253,6 +253,10 @@ func (a API) PaymentConfirm(w http.ResponseWriter, r http.Request) error {`
`253`	`253`	`}`
`254`	`254`	`}`
`255`	`255`
	`256`	`+ if trans.Status == models.PaidState {`
	`257`	`+ return sendJSON(w, http.StatusOK, trans)`
	`258`	`+ }`
	`259`	`+`
`256`	`260`	`order := &models.Order{}`
`257`	`261`	`if rsp := a.db.Find(order, "id = ?", trans.OrderID); rsp.Error != nil {`
`258`	`262`	`if rsp.RecordNotFound() {`