Skip to content

Commit 595e55a

Browse files
author
Mateusz
committed
changes to workflows - release and checks
install steps in cheks now wait for resources, archive is no longer in the branch - it is pulled during the tests and release.
1 parent 138f84e commit 595e55a

File tree

5 files changed

+87
-29
lines changed

5 files changed

+87
-29
lines changed

.github/workflows/checks.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@ jobs:
4040
run: |
4141
helm repo add opentelemetry-collector https://open-telemetry.github.io/opentelemetry-helm-charts
4242
43+
- name: Build chart dependencies
44+
run: |
45+
helm dependency build charts/netdata
46+
4347
- name: Check documentation is up-to-date
4448
run: |
4549
./generate-documentation.sh

.github/workflows/release.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,19 @@ jobs:
2929
git config --global user.name Netdatabot
3030
git config --global user.email bot@netdata.cloud
3131
32+
- name: Set up Helm
33+
uses: azure/setup-helm@v4
34+
with:
35+
version: v3.12.0
36+
37+
- name: Add helm repo for dependencies
38+
run: |
39+
helm repo add opentelemetry-collector https://open-telemetry.github.io/opentelemetry-helm-charts
40+
41+
- name: Build chart dependencies
42+
run: |
43+
helm dependency build charts/netdata
44+
3245
- name: Get current version
3346
id: get_current_var
3447
run: echo "current_version=$(.github/scripts/update_versions.py get_chart_version)" >> $GITHUB_OUTPUT

charts/netdata/README.md

Lines changed: 54 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1049,6 +1049,15 @@ true
10491049
</td>
10501050
<td>When a liveness probe fails, Kubernetes will try failureThreshold times before giving up. Giving up the liveness probe means restarting the container</td>
10511051
</tr>
1052+
<tr>
1053+
<td>child.livenessProbe.periodSeconds</td>
1054+
<td>int</td>
1055+
<td><pre lang="json">
1056+
30
1057+
</pre>
1058+
</td>
1059+
<td>How often (in seconds) to perform the liveness probe</td>
1060+
</tr>
10521061
<tr>
10531062
<td>child.livenessProbe.successThreshold</td>
10541063
<td>int</td>
@@ -1312,26 +1321,6 @@ false
13121321
</tr>
13131322
</tbody>
13141323
</table>
1315-
<h3>Child1.0</h3>
1316-
<table>
1317-
<thead>
1318-
<th>Key</th>
1319-
<th>Type</th>
1320-
<th>Default</th>
1321-
<th>Description</th>
1322-
</thead>
1323-
<tbody>
1324-
<tr>
1325-
<td>child.livenessProbe.periodSeconds</td>
1326-
<td>int</td>
1327-
<td><pre lang="json">
1328-
30
1329-
</pre>
1330-
</td>
1331-
<td>How often (in seconds) to perform the liveness probe</td>
1332-
</tr>
1333-
</tbody>
1334-
</table>
13351324
<h3>K8s State</h3>
13361325
<table>
13371326
<thead>
@@ -1712,6 +1701,51 @@ false
17121701
</td>
17131702
<td>Service annotations</td>
17141703
</tr>
1704+
<tr>
1705+
<td>netdataOpentelemetry.service.clusterIP</td>
1706+
<td>string</td>
1707+
<td><pre lang="json">
1708+
""
1709+
</pre>
1710+
</td>
1711+
<td>Cluster IP address (only used with service.type ClusterIP)</td>
1712+
</tr>
1713+
<tr>
1714+
<td>netdataOpentelemetry.service.loadBalancerIP</td>
1715+
<td>string</td>
1716+
<td><pre lang="json">
1717+
""
1718+
</pre>
1719+
</td>
1720+
<td>LoadBalancer IP address (only used with service.type LoadBalancer)</td>
1721+
</tr>
1722+
<tr>
1723+
<td>netdataOpentelemetry.service.loadBalancerSourceRanges</td>
1724+
<td>list</td>
1725+
<td><pre lang="json">
1726+
[]
1727+
</pre>
1728+
</td>
1729+
<td>Allowed source ranges for LoadBalancer (only used with service.type LoadBalancer)</td>
1730+
</tr>
1731+
<tr>
1732+
<td>netdataOpentelemetry.service.externalTrafficPolicy</td>
1733+
<td>string</td>
1734+
<td><pre lang="json">
1735+
""
1736+
</pre>
1737+
</td>
1738+
<td>External traffic policy (only used with service.type LoadBalancer)</td>
1739+
</tr>
1740+
<tr>
1741+
<td>netdataOpentelemetry.service.healthCheckNodePort</td>
1742+
<td>string</td>
1743+
<td><pre lang="json">
1744+
""
1745+
</pre>
1746+
</td>
1747+
<td>Health check node port (only used with service.type LoadBalancer and external traffic policy Local)</td>
1748+
</tr>
17151749
<tr>
17161750
<td>netdataOpentelemetry.resources</td>
17171751
<td>object</td>
-31 KB
Binary file not shown.

charts/netdata/values.yaml

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,7 @@ child:
454454
# @section -- Child
455455
failureThreshold: 3
456456
# -- How often (in seconds) to perform the liveness probe
457-
# @section -- Child1.0
457+
# @section -- Child
458458
periodSeconds: 30
459459
# -- Minimum consecutive successes for the liveness probe to be considered successful after having failed
460460
# @section -- Child
@@ -871,14 +871,21 @@ netdataOpentelemetry:
871871
# -- Service annotations
872872
# @section -- Netdata OpenTelemetry
873873
annotations: {}
874-
## Only to be used with type LoadBalancer
875-
# loadBalancerIP: 10.0.1.69
876-
# loadBalancerSourceRanges: []
877-
# externalTrafficPolicy: Local
878-
## Only to be used with type LoadBalancer and external traffic policy Local
879-
# healthCheckNodePort:
880-
## Only to be used with type ClusterIP
881-
# clusterIP: 10.1.2.3
874+
# -- Cluster IP address (only used with service.type ClusterIP)
875+
# @section -- Netdata OpenTelemetry
876+
clusterIP: ""
877+
# -- LoadBalancer IP address (only used with service.type LoadBalancer)
878+
# @section -- Netdata OpenTelemetry
879+
loadBalancerIP: ""
880+
# -- Allowed source ranges for LoadBalancer (only used with service.type LoadBalancer)
881+
# @section -- Netdata OpenTelemetry
882+
loadBalancerSourceRanges: []
883+
# -- External traffic policy (only used with service.type LoadBalancer)
884+
# @section -- Netdata OpenTelemetry
885+
externalTrafficPolicy: ""
886+
# -- Health check node port (only used with service.type LoadBalancer and external traffic policy Local)
887+
# @section -- Netdata OpenTelemetry
888+
healthCheckNodePort: ""
882889

883890
# -- Compute resources required by this Deployment
884891
# @section -- Netdata OpenTelemetry

0 commit comments

Comments
 (0)