Skip to content

tftpmenu not loaded if tftp filename has a path component #1097

Closed
@abh

Description

@abh

I load ipxe over tftp from a path (ipxe/netboot.xyz.kpxe). If I'm not mistaken (which is very possible) that's what makes this line from netboot.xyz.j2 not match:

isset ${tftp-server} && iseq ${filename} {{ bootloader_filename }}.kpxe && goto tftpmenu ||

It's not clear to me what the iseq part is supposed to be accomplishing. I am guessing there are some filenames that shouldn't go to tftpmenu, but if so I'd suggest those should be called out rather than the opposite. (And if they shouldn't be going to tftpmenu, would they ever be running in a context with tftp-server set?).

I believe this section should be replaced with just a line like:

isset ${tftp-server} && goto tftpmenu || goto menu

(at least for my use case this fixed it so I can use MAC-[mac-address].ipxe).

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions