Skip to content

Commit 20f59dd

Browse files
[signal] adjust log levels (#3813)
1 parent 2f34e98 commit 20f59dd

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

signal/peer/peer.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ func (registry *Registry) Register(peer *Peer) {
7979
p, loaded := registry.Peers.LoadOrStore(peer.Id, peer)
8080
if loaded {
8181
pp := p.(*Peer)
82-
log.Warnf("peer [%s] is already registered [new streamID %d, previous StreamID %d]. Will override stream.",
82+
log.Debugf("peer [%s] is already registered [new streamID %d, previous StreamID %d]. Will override stream.",
8383
peer.Id, peer.StreamID, pp.StreamID)
8484
registry.Peers.Store(peer.Id, peer)
8585
return
@@ -104,7 +104,7 @@ func (registry *Registry) Deregister(peer *Peer) {
104104
pp := p.(*Peer)
105105
if peer.StreamID < pp.StreamID {
106106
registry.Peers.Store(peer.Id, p)
107-
log.Warnf("attempted to remove newer registered stream of a peer [%s] [newer streamID %d, previous StreamID %d]. Ignoring.",
107+
log.Debugf("attempted to remove newer registered stream of a peer [%s] [newer streamID %d, previous StreamID %d]. Ignoring.",
108108
peer.Id, pp.StreamID, peer.StreamID)
109109
return
110110
}

signal/server/signal.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import (
66
"io"
77
"time"
88

9-
"github.com/netbirdio/signal-dispatcher/dispatcher"
109
log "github.com/sirupsen/logrus"
1110
"go.opentelemetry.io/otel/attribute"
1211
"go.opentelemetry.io/otel/metric"
@@ -15,6 +14,8 @@ import (
1514
"google.golang.org/grpc/status"
1615
gproto "google.golang.org/protobuf/proto"
1716

17+
"github.com/netbirdio/signal-dispatcher/dispatcher"
18+
1819
"github.com/netbirdio/netbird/signal/metrics"
1920
"github.com/netbirdio/netbird/signal/peer"
2021
"github.com/netbirdio/netbird/signal/proto"
@@ -69,7 +70,7 @@ func NewServer(ctx context.Context, meter metric.Meter) (*Server, error) {
6970

7071
// Send forwards a message to the signal peer
7172
func (s *Server) Send(ctx context.Context, msg *proto.EncryptedMessage) (*proto.EncryptedMessage, error) {
72-
log.Debugf("received a new message to send from peer [%s] to peer [%s]", msg.Key, msg.RemoteKey)
73+
log.Tracef("received a new message to send from peer [%s] to peer [%s]", msg.Key, msg.RemoteKey)
7374

7475
if _, found := s.registry.Get(msg.RemoteKey); found {
7576
s.forwardMessageToPeer(ctx, msg)
@@ -112,7 +113,7 @@ func (s *Server) ConnectStream(stream proto.SignalExchange_ConnectStreamServer)
112113
return err
113114
}
114115

115-
log.Debugf("Received a response from peer [%s] to peer [%s]", msg.Key, msg.RemoteKey)
116+
log.Tracef("Received a response from peer [%s] to peer [%s]", msg.Key, msg.RemoteKey)
116117

117118
_, err = s.dispatcher.SendMessage(stream.Context(), msg)
118119
if err != nil {
@@ -149,7 +150,7 @@ func (s *Server) DeregisterPeer(p *peer.Peer) {
149150
}
150151

151152
func (s *Server) forwardMessageToPeer(ctx context.Context, msg *proto.EncryptedMessage) {
152-
log.Debugf("forwarding a new message from peer [%s] to peer [%s]", msg.Key, msg.RemoteKey)
153+
log.Tracef("forwarding a new message from peer [%s] to peer [%s]", msg.Key, msg.RemoteKey)
153154
getRegistrationStart := time.Now()
154155

155156
// lookup the target peer where the message is going to

0 commit comments

Comments
 (0)