Skip to content

Flawed Python versioning check #13

@mathscantor

Description

@mathscantor

Hi, I would like to point out an issue regarding the versioning check at start of deploy.py.

I'm currently on python 3.12.4 and the tuple comparison is not comparing integers but strings.
You can reproduce the bug with the python console commands below:

Python 3.12.4 | packaged by Anaconda, Inc. | (main, Jun 18 2024, 15:12:24) [GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> ('3', '9', '4') < ('3', '2', '0')
False
>>> ('3', '10', '4') < ('3', '2', '0')
True
>>> '10' < '2'
True

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions