Is DpCat required as part of the topology?

[keck-in-space]

Hello, I am trying to remove DpCat as it is not a functionality we plan to use, however when I comment out the subtopology, as shown below, I get errors.

  # ----------------------------------------------------------------------
  # Subtopology imports
  # ----------------------------------------------------------------------
    import CdhCore.Subtopology
    import ComCcsds.Subtopology
    # import DataProducts.Subtopology
    import FileHandling.Subtopology

It would appear that the deploymentSubtopologyDefs.hpp is hardcoded to expect DataProducts to exist.

/**
 * \brief required type definition to carry state
 *
 * The topology autocoder requires an object that carries state with the name `FW1Testing::TopologyState`. Only the type
 * definition is required by the autocoder and the contents of this object are otherwise opaque to the autocoder. The
 * contents are entirely up to the definition of the project. This deployment uses subtopologies.
 */
struct TopologyState {
    const char* hostname;   //!< Hostname for TCP communication
    U16 port;              //!< Port for TCP communication
    CdhCore::SubtopologyState cdhCore;           //!< Subtopology state for CdhCore
    ComCcsds::SubtopologyState comCcsds;         //!< Subtopology state for ComCcsds 
    DataProducts::SubtopologyState dataProducts; //!< Subtopology state for DataProducts
    FileHandling::SubtopologyState fileHandling; //!< Subtopology state for FileHandling
};

This is after a purge and build.

/repo/lib/fprime/Svc/Subtopologies/DataProducts/SubtopologyTopologyDefs.hpp:8:10: fatal error: Svc/Subtopologies/DataProducts/DataProductsConfig/FppConstantsAc.hpp: No such file or directory
    8 | #include "Svc/Subtopologies/DataProducts/DataProductsConfig/FppConstantsAc.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[thomas-bc]

If you're trying to remove DataProducts from your deployment entirely, you can and should remove those lines and anything else that mentions them:

    DataProducts::SubtopologyState dataProducts; //!< Subtopology state for DataProducts

#include "Svc/Subtopologies/DataProducts/DataProductsConfig/FppConstantsAc.hpp"

[keck-in-space]

Thank you! I didn't know if updating the topology.fpp should have automatically removed these. Manually removing them works.