Skip to content

Web Socket breaks when upgrading to 1.95.0 #15706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
octionicsolutions opened this issue May 26, 2025 · 7 comments · May be fixed by #15761
Open

Web Socket breaks when upgrading to 1.95.0 #15706

octionicsolutions opened this issue May 26, 2025 · 7 comments · May be fixed by #15761
Labels
in linear Issue or PR has been created in Linear for internal review

Comments

@octionicsolutions
Copy link

octionicsolutions commented May 26, 2025 •
edited by netroy
Loading

Bug Description

When upgrading to version 1.95.0 the editor does not work properly anymore. It shows "lost connection". Thus it is not possible to execute workflows in test mode. The rest of the app seems to work fine though.

Image

Log Output:

n8n-02-n8n       | 2025-05-26T15:01:14.599Z | debug | Skipped browserId check on /rest/push {"file":"auth.service.js","function":"resolveJwt"}
n8n-02-n8n       | 2025-05-26T15:01:14.601Z | warn | Origin header does NOT match the expected origin. (Origin: "https://n8n.mydomain.com", Expected: "wss://n8n.mydomain.com") {"scopes":["push"],"expectedOrigin":"wss://n8n.mydomain.com","headers":{"host":"n8n.mydomain.com","origin":"https://n8n.mydomain.com","x-forwarded-proto":"wss","x-forwarded-host":"n8n.mydomain.com"},"file":"index.js","function":"handleRequest"}

To Reproduce

  • Update to version 1.94.0 to 1.95.0
  • Open any workflow

Expected behavior

Editor working again without showing connection error in top right corner.

Operating System

Ubuntu Server 22.04 LTS

n8n Version

1.95.0

Node.js Version

n/A

Database

PostgreSQL

Execution mode

main (default)
@Joffcom
Copy link
Member

Joffcom commented May 26, 2025

Hey @octionicsolutions,

We have created an internal ticket to look into this which we will be tracking as "GHC-2175"

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label May 26, 2025
@netroy
Copy link
Member

netroy commented May 26, 2025

Can you please share what reverse-proxy you are using in this setup?

@Joffcom Joffcom added the Needs Feedback Waiting for further input or clarification. label May 26, 2025
@octionicsolutions
Copy link
Author

Using traefik. Worked with this docker compose config flawlessly in 1.94.0

labels:
- traefik.enable=true
- traefik.http.routers.${SERVICE_NAME}.rule=Host(${SERVICE_URL})
- traefik.http.routers.${SERVICE_NAME}.entrypoints=https
- traefik.http.routers.${SERVICE_NAME}.tls=true
- traefik.http.routers.${SERVICE_NAME}.tls.certresolver=letsencrypt
- traefik.http.services.${SERVICE_NAME}.loadbalancer.server.port=5678

@Joffcom Joffcom removed the Needs Feedback Waiting for further input or clarification. label May 26, 2025
@netroy
Copy link
Member

netroy commented May 26, 2025

I think the issue might be that we are checking only for https and not for wss in this code block.

@Joffcom Joffcom added the Needs Feedback Waiting for further input or clarification. label May 26, 2025
@octionicsolutions
Copy link
Author

Looks like it.
Would be great to have backwards compatibility here, so I do not need to implement a traefik middleware on all environments to hack around this issue.

@Joffcom Joffcom removed the Needs Feedback Waiting for further input or clarification. label May 26, 2025
@netroy netroy linked a pull request May 27, 2025 that will close this issue
Open
4 tasks
@leobaldoneto
Copy link

Can I downgrade the version until it's fixed?

@octionicsolutions
Copy link
Author

Can I downgrade the version until it's fixed?

It worked for me. But always comes with a risk I think.

@Joffcom Joffcom marked this as a duplicate of #15811 May 29, 2025
@Joffcom Joffcom mentioned this issue May 29, 2025
Closed
@Joffcom Joffcom marked this as a duplicate of #15744 May 29, 2025
@Joffcom Joffcom mentioned this issue May 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): Simplify Websocket origin security checks n8n-io/n8n
4 participants
@netroy @Joffcom @leobaldoneto @octionicsolutions