Logging of Array Parameters

[a96219]

Logging of Array Parameters

1. In Logging of Array parameters #742 #761, only java.sql.Array is supported.Do you consider supporting regular Java arrays as well?
2. The PostgreSQL driver maps regular Java arrays directly to PostgreSQL array types without requiring a TypeHandler or java.sql.Array.

The method org.apache.ibatis.reflection.ArrayUtil#toString(Object obj)

mybatis-3/src/main/java/org/apache/ibatis/reflection/ArrayUtil.java

Lines 119 to 157 in fca05b7

	/**
	* If the {@code obj} is an array, toString() method of {@link Arrays} is called. Otherwise {@link Object#toString()}
	* is called. Returns "null" if {@code obj} is <code>null</code>.
	*
	* @param obj
	* An object. May be an array or <code>null</code>.
	*
	* @return String representation of the {@code obj}.
	*/
	public static String toString(Object obj) {
	if (obj == null) {
	return "null";
	}
	final Class<?> clazz = obj.getClass();
	if (!clazz.isArray()) {
	return obj.toString();
	}
	final Class<?> componentType = obj.getClass().getComponentType();
	if (long.class.equals(componentType)) {
	return Arrays.toString((long[]) obj);
	}
	if (int.class.equals(componentType)) {
	return Arrays.toString((int[]) obj);
	} else if (short.class.equals(componentType)) {
	return Arrays.toString((short[]) obj);
	} else if (char.class.equals(componentType)) {
	return Arrays.toString((char[]) obj);
	} else if (byte.class.equals(componentType)) {
	return Arrays.toString((byte[]) obj);
	} else if (boolean.class.equals(componentType)) {
	return Arrays.toString((boolean[]) obj);
	} else if (float.class.equals(componentType)) {
	return Arrays.toString((float[]) obj);
	} else if (double.class.equals(componentType)) {
	return Arrays.toString((double[]) obj);
	} else {
	return Arrays.toString((Object[]) obj);
	}
	}

already supports:

• null
• normal objects
• array objects

It seems that all we need to do is adjust Method org.apache.ibatis.logging.jdbc.BaseJdbcLogger#objectValueString(Object value):

mybatis-3/src/main/java/org/apache/ibatis/logging/jdbc/BaseJdbcLogger.java

Lines 100 to 109 in fca05b7

	protected String objectValueString(Object value) {
	if (value instanceof Array) {
	try {
	return ArrayUtil.toString(((Array) value).getArray());
	} catch (SQLException e) {
	// Intentionally fall through to return value.toString()
	}
	}
	return value.toString();
	}

Specifically, change:

mybatis-3/src/main/java/org/apache/ibatis/logging/jdbc/BaseJdbcLogger.java

Line 108 in fca05b7

return value.toString();

to

return ArrayUtil.toString(value);