Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Commit 12f2e74

Browse files
wangxianzhumoz-wptsync-bot
wangxianzhu
authored and
moz-wptsync-bot
committed
Bug 1642484 [wpt PR 23900] - Remove MainThreadScrollingReasons::kHasClipRelatedProperty, a=testonly
Automatic update from web-platform-tests Remove MainThreadScrollingReasons::kHasClipRelatedProperty We no longer need to skip composited scrolling for css clip and clip-path since (perhaps) BlinkGenPropertyTrees. In compositor, when we hit test on a layer with special clip/mask, we'll still fallback to main thread hit testing/scrolling because only the main thread knows which area is hit testable. This is achieved by cc::LayerTreeHostImpl::IsInitialScrollHitTestReliable() returning false. Bug: 1074395 Change-Id: I91260b063879812ca82928fe783de25c4b6732a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225229 Commit-Queue: Xianzhu Wang <[email protected]> Reviewed-by: Philip Rogers <[email protected]> Reviewed-by: Robert Flack <[email protected]> Reviewed-by: David Bokan <[email protected]> Cr-Commit-Position: refs/heads/master@{#774232} -- wpt-commits: 4c2484a55b58a72b74c0b6c55ab0238cf11efb4a wpt-pr: 23900
1 parent bd3ccce commit 12f2e74

File tree

4 files changed

+58
-0
lines changed

4 files changed

+58
-0
lines changed

‎testing/web-platform/tests/css/css-masking/clip-path/clip-path-scroll.html‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
<!DOCTYPE html>
2+
<title>CSS Masking: Test clip-path property with overflow:scroll</title>
3+
<link rel="help" href="http://www.w3.org/TR/css-masking-1/#clip-path-property">
4+
<link rel="match" href="reference/clip-path-scroll-ref.html">
5+
<html class="reftest-wait">
6+
<p>The test passes if there is a green square containing text (which can be scrolled
7+
with mouse wheel or touch). No scrollbars should be seen.</p>
8+
<div id="target" style="clip-path: polygon(10px 10px, 10px 100px, 100px 100px, 100px 10px);
9+
width: 200px; height: 200px; overflow: scroll; background: red">
10+
<div style="position: relative; top: 100px;
11+
width: 100px; height: 100px; background: green">
12+
</div>
13+
<div style="height: 1000px"></div>
14+
</div>
15+
<script>
16+
requestAnimationFrame(() => {
17+
requestAnimationFrame(() => {
18+
target.scrollTop = 100;
19+
document.documentElement.classList.remove("reftest-wait");
20+
});
21+
});
22+
</script>
23+
</html>
24+

‎testing/web-platform/tests/css/css-masking/clip-path/reference/clip-path-scroll-ref.html‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<!DOCTYPE html>
2+
<p>The test passes if there is a green square containing text (which can be scrolled
3+
with mouse wheel or touch). No scrollbars should be seen.</p>
4+
<div style="position: relative; top: 10px; left: 10px; width: 90px; height: 90px; background: green">
5+
</div>

‎testing/web-platform/tests/css/css-masking/clip/clip-rect-scroll.html‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
<!DOCTYPE html>
2+
<title>CSS Masking: Test clip property with rect function with overflow:scroll</title>
3+
<link rel="help" href="http://www.w3.org/TR/css-masking-1/#clip-property">
4+
<link rel="match" href="reference/clip-rect-scroll-ref.html">
5+
<html class="reftest-wait">
6+
<p>The test passes if there is a green square containing text (which can be scrolled
7+
with mouse wheel or touch). No scrollbars should be seen.</p>
8+
<div id="target" style="position: absolute; clip: rect(10px,100px,100px,10px);
9+
width: 200px; height: 200px; overflow: scroll; background: red">
10+
<div style="position: relative; top: 100px;
11+
width: 100px; height: 100px; background: green">
12+
</div>
13+
<div style="height: 1000px"></div>
14+
</div>
15+
<script>
16+
requestAnimationFrame(() => {
17+
requestAnimationFrame(() => {
18+
target.scrollTop = 100;
19+
document.documentElement.classList.remove("reftest-wait");
20+
});
21+
});
22+
</script>
23+
</html>
24+

‎testing/web-platform/tests/css/css-masking/clip/reference/clip-rect-scroll-ref.html‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<!DOCTYPE html>
2+
<p>The test passes if there is a green square containing text (which can be scrolled
3+
with mouse wheel or touch). No scrollbars should be seen.</p>
4+
<div style="position: relative; top: 10px; left: 10px; width: 90px; height: 90px; background: green">
5+
</div>

0 commit comments

Comments
 (0)