Unable to open a popup with redirect

[nbhasin2]

Steps to reproduce

• Go to https://www.pillarstudios.ca/book
• Tap on any item
• Wait for the popup to open

Expected behavior

• Booking website with square should open

Actual behavior

• About blank opens

Device & build information

• Device: iPhone 16 Pro
• Build version: Firefox Beta 9000 (68726)
• First seen version: Firefox 9000 (68726)

Notes

Attachments:

trim.7753529C-3AC2-4CB2-A664-9C515253EC6F.MOV

┆Issue is synchronized with this Jira Task

[cpeterso]

I bisected this regression to Nightly 9000 (68696). The previous Nightly build, 9000 (68643), opens the links correctly.

I experienced this bug when trying to open a URL pasted into the Google Translate website.

STR:

1. Open https://translate.google.com/?sl=auto&tl=en&text=https%3A%2F%2Fes.wikipedia.org%2Fwiki%2FMozilla_Firefox&op=translate
2. Tap with Wikipedia link to open the translated page in a new tab.

[janbrasna]

Can be also verified simply with https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_win_open

This does not reproduce on 148.2 RC, it's only Nightly 68696 and later (previous 68643 works):

Build timeline [+]

I was suspecting 914bd1e … however I have needs-reload-refactor disabled by default — when I actually ENABLE the flag, the breakage fixes itself. It looks like the flag logic might be reversed somewhere; will link this in the PR.