Skip to content

Commit e788756

Browse files
committed
[fea] revert prefetch
1 parent 04d3ab2 commit e788756

File tree

3 files changed

+10
-21
lines changed

3 files changed

+10
-21
lines changed

pypi_server/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
("Dmitry Orlov", "[email protected]")
1010
]
1111

12-
version_info = (0, 3, 7)
12+
version_info = (0, 3, 8)
1313

1414
__version__ = ".".join(map(str, version_info))
1515
__author__ = ", ".join("{0} <{1}>".format(*author) for author in author_info)

pypi_server/db/packages.py

Lines changed: 8 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -113,20 +113,7 @@ def files(self, version=None):
113113
if version:
114114
version = self.find_version(version)
115115

116-
if version:
117-
versions = PackageVersion.select().where(
118-
PackageFile.version == version,
119-
PackageVersion.package == self
120-
)
121-
else:
122-
versions = PackageVersion.select().where(
123-
PackageVersion.hidden == False,
124-
PackageVersion.package == self
125-
)
126-
127-
packages = Package.select().where(Package.id == self.id)
128-
129-
files = PackageFile.select(
116+
q = PackageFile.select(
130117
Package,
131118
PackageVersion,
132119
PackageFile
@@ -136,10 +123,15 @@ def files(self, version=None):
136123
Package
137124
).where(
138125
Package.id == self.id
139-
).order_by(Package.name.asc())
126+
)
127+
128+
if version:
129+
q = q.where(PackageFile.version == version)
130+
else:
131+
q = q.where(PackageVersion.hidden == False)
140132

141133
return sorted(
142-
p.prefetch(files, packages, versions),
134+
q.order_by(Package.name.asc()),
143135
key=lambda x: x.version.version,
144136
reverse=True,
145137
)
@@ -159,10 +151,7 @@ def versions(self, show_hidden=False):
159151
q = q.where(PackageVersion.hidden == False)
160152

161153
return sorted(
162-
p.prefetch(
163154
q,
164-
Package.select().where(Package.id == self.id),
165-
),
166155
key=lambda x: x.version,
167156
reverse=True
168157
)

pypi_server/templates/simple/files.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
{% block "body" %}
66
<h1>Files for {{ package }}</h1>
77
{% for file in files %}
8-
<a href="/simple/{{ file.package.name }}/{{ file.version.version }}/{{ file.basename }}#md5={{ file.md5 }}" rel="internal" class="file">{{ file.basename }}</a>
8+
<a href="/simple/{{ package }}/{{ file.version.version }}/{{ file.basename }}#md5={{ file.md5 }}" rel="internal" class="file">{{ file.basename }}</a>
99
{% end %}
1010

1111
{% end %}

0 commit comments

Comments
 (0)