SERVER-100116 Set up rules_lint with eslint (#32036)

GitOrigin-RevId: b358136

Author: zackwintermdb

.github/CODEOWNERS

@@ -14,14 +14,14 @@ OWNERS.yml @10gen/server-root-ownership @svc-auto-approve-bot
 .clang-format @10gen/server-programmability @svc-auto-approve-bot
 .clang-tidy.in @10gen/server-programmability @svc-auto-approve-bot
 .eslintignore @10gen/devprod-correctness @svc-auto-approve-bot
-.eslintrc.yml @10gen/devprod-correctness @svc-auto-approve-bot
 .gitignore @10gen/devprod-build @svc-auto-approve-bot
 .mypy.ini @10gen/devprod-build @10gen/devprod-correctness @svc-auto-approve-bot
 .prettierignore @10gen/devprod-correctness @svc-auto-approve-bot
 .prettierrc @10gen/devprod-correctness @svc-auto-approve-bot
 /BUILD.bazel @10gen/devprod-build @svc-auto-approve-bot
 copy.bara.sky @IamXander @smcclure15 @svc-auto-approve-bot
 copy.bara.staging.sky @10gen/devprod-correctness @svc-auto-approve-bot
+eslint.config.mjs @10gen/devprod-correctness @svc-auto-approve-bot
 jsconfig.json @10gen/devprod-correctness @svc-auto-approve-bot
 package.json @10gen/devprod-correctness @svc-auto-approve-bot
 pnpm-lock.yaml @10gen/devprod-correctness @svc-auto-approve-bot

.gitignore

@@ -269,7 +269,7 @@ node_modules/
 package-lock.json
 
 # jstestfuzz generated test directory
-jstestfuzz/
+/jstestfuzz/
 
 # Bazel-related work
 # (Note that each string does NOT terminate with a '/' so that gitignore works properly)

.npmrc

@@ -0,0 +1 @@
+hoist=false

BUILD.bazel

@@ -2,6 +2,8 @@ load("@npm//:defs.bzl", "npm_link_all_packages")
 load("//bazel/install_rules:install_rules.bzl", "mongo_install")
 load("//bazel/toolchains:mongo_toolchain.bzl", "setup_mongo_toolchain_aliases")
 load("//bazel/config:render_template.bzl", "render_template")
+load("@npm//:eslint/package_json.bzl", eslint_bin = "bin")
+load("@aspect_rules_js//js:defs.bzl", "js_library")
 
 package(
     default_visibility = ["//visibility:public"],
@@ -16,11 +18,33 @@ exports_files([
 
 npm_link_all_packages(name = "node_modules")
 
+js_library(
+    name = "eslintrc",
+    srcs = ["eslint.config.mjs"],
+    deps = [
+        ":node_modules/@eslint/js",
+        ":node_modules/globals",
+        "//:node_modules/@eslint/eslintrc",
+    ],
+)
+
+eslint_bin.eslint_binary(
+    name = "eslint",
+    data = [
+        "//:eslintrc",
+    ],
+)
+
 alias(
     name = "format",
     actual = "//bazel/format",
 )
 
+alias(
+    name = "lint",
+    actual = "//bazel:lint",
+)
+
 alias(
     name = "codeowners",
     actual = "//buildscripts:codeowners",

OWNERS.yml

@@ -24,9 +24,6 @@ filters:
   - ".eslintignore":
     approvers:
       - 10gen/devprod-correctness
-  - ".eslintrc.yml":
-    approvers:
-      - 10gen/devprod-correctness
   - ".gitignore":
     approvers:
       - 10gen/devprod-build
@@ -50,6 +47,9 @@ filters:
   - "copy.bara.staging.sky":
     approvers:
       - 10gen/devprod-correctness
+  - "eslint.config.mjs":
+    approvers:
+      - 10gen/devprod-correctness
   - "jsconfig.json":
     approvers:
       - 10gen/devprod-correctness

WORKSPACE.bazel

@@ -34,6 +34,78 @@ http_archive(
     ],
 )
 
+load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
+
+http_archive(
+    name = "aspect_rules_lint",
+    sha256 = "f60e4a737a5e09402f5fa3bd182efa80dac5523ca4b9bc5c6fa8c06fbfb46630",
+    strip_prefix = "rules_lint-1.1.0",
+    url = "https://github.com/aspect-build/rules_lint/releases/download/v1.1.0/rules_lint-v1.1.0.tar.gz",
+)
+
+# aspect_rules_lint depends on aspect_bazel_lib.
+http_archive(
+    name = "aspect_bazel_lib",
+    sha256 = "6d758a8f646ecee7a3e294fbe4386daafbe0e5966723009c290d493f227c390b",
+    strip_prefix = "bazel-lib-2.7.7",
+    url = "https://github.com/aspect-build/bazel-lib/releases/download/v2.7.7/bazel-lib-v2.7.7.tar.gz",
+)
+
+load("@aspect_bazel_lib//lib:repositories.bzl", "aspect_bazel_lib_dependencies")
+
+# aspect_bazel_lib depends on bazel_skylib
+aspect_bazel_lib_dependencies()
+
+load(
+    "@aspect_rules_lint//format:repositories.bzl",
+    # Fetch additional formatter binaries you need:
+    "fetch_java_format",
+    "fetch_ktfmt",
+    "fetch_swiftformat",
+    "rules_lint_dependencies",
+)
+
+rules_lint_dependencies()
+
+fetch_java_format()
+
+fetch_ktfmt()
+
+fetch_swiftformat()
+
+load("@aspect_rules_lint//lint:checkstyle.bzl", "fetch_checkstyle")
+
+fetch_checkstyle()
+
+load("@aspect_rules_lint//lint:pmd.bzl", "fetch_pmd")
+
+fetch_pmd()
+
+load("@aspect_rules_lint//lint:vale.bzl", "fetch_vale")
+
+fetch_vale()
+
+load("@aspect_rules_lint//lint:ktlint.bzl", "fetch_ktlint")
+
+fetch_ktlint()
+
+load("@aspect_rules_lint//lint:spotbugs.bzl", "fetch_spotbugs")
+
+fetch_spotbugs()
+
+########################
+# Optional: multitool provides defaults for some tools such as yamlfmt
+# If you do not set up multitool, you must provide these tools yourself
+load("@rules_multitool//multitool:multitool.bzl", "multitool")
+
+multitool(
+    name = "multitool",
+    lockfiles = [
+        "@aspect_rules_lint//format:multitool.lock.json",
+        "@aspect_rules_lint//lint:multitool.lock.json",
+    ],
+)
+
 load("//bazel/platforms:local_config_platform.bzl", "setup_local_config_platform")
 load("//bazel/toolchains:mongo_toolchain.bzl", "toolchain_download")
 
@@ -165,34 +237,32 @@ poetry(
 
 http_archive(
     name = "aspect_rules_js",
-    sha256 = "630a71aba66c4023a5b16ab3efafaeed8b1a2865ccd168a34611eb73876b3fc4",
-    strip_prefix = "rules_js-1.37.1",
+    sha256 = "875b8d01af629dbf626eddc5cf239c9f0da20330f4d99ad956afc961096448dd",
+    strip_prefix = "rules_js-2.1.3",
     urls = [
         # Implements retry by relisting each url multiple times to be used as a failover.
         # TODO(SERVER-86719): Re-implement http_archive to allow sleeping between retries
-        "https://github.com/aspect-build/rules_js/releases/download/v1.37.1/rules_js-v1.37.1.tar.gz",
-        "https://github.com/aspect-build/rules_js/releases/download/v1.37.1/rules_js-v1.37.1.tar.gz",
-        "https://github.com/aspect-build/rules_js/releases/download/v1.37.1/rules_js-v1.37.1.tar.gz",
-        "https://github.com/aspect-build/rules_js/releases/download/v1.37.1/rules_js-v1.37.1.tar.gz",
-        "https://github.com/aspect-build/rules_js/releases/download/v1.37.1/rules_js-v1.37.1.tar.gz",
+        "https://github.com/aspect-build/rules_js/releases/download/v2.1.3/rules_js-v2.1.3.tar.gz",
+        "https://github.com/aspect-build/rules_js/releases/download/v2.1.3/rules_js-v2.1.3.tar.gz",
+        "https://github.com/aspect-build/rules_js/releases/download/v2.1.3/rules_js-v2.1.3.tar.gz",
+        "https://github.com/aspect-build/rules_js/releases/download/v2.1.3/rules_js-v2.1.3.tar.gz",
+        "https://github.com/aspect-build/rules_js/releases/download/v2.1.3/rules_js-v2.1.3.tar.gz",
     ],
 )
 
 load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")
 
 rules_js_dependencies()
 
-load("@rules_nodejs//nodejs:repositories.bzl", "DEFAULT_NODE_VERSION", "nodejs_register_toolchains")
+load("@aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")
 
-nodejs_register_toolchains(
-    name = "nodejs",
-    node_version = DEFAULT_NODE_VERSION,
-)
+rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)
 
 load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")
 
 npm_translate_lock(
     name = "npm",
+    npmrc = "//:.npmrc",
     pnpm_lock = "//:pnpm-lock.yaml",
     verify_node_modules_ignored = "//:.bazelignore",
 )

bazel/BUILD.bazel

@@ -5,3 +5,10 @@ exports_files([
     "scons_link_list.py",
     "install_rules.py",
 ])
+
+sh_binary(
+    name = "lint",
+    srcs = ["lint.sh"],
+    args = ["//..."],
+    visibility = ["//visibility:public"],
+)

bazel/lint.sh

@@ -0,0 +1,2 @@
+# placeholder for bazel/wrapper_hook/lint.py
+echo "No linter errors found!"