SERVER-105664 tag forced inlining decisions that are for temporarily buying back v5 toolchain regressions (#36846)

GitOrigin-RevId: acbec25e7902d3a0e8e817550879080499566fd3

Author: jpbronsted

src/mongo/bson/column/bsoncolumn.inl

@@ -32,7 +32,7 @@ namespace bsoncolumn {
 
 template <class Buffer>
 requires Appendable<Buffer>
-MONGO_COMPILER_ALWAYS_INLINE void BSONColumnBlockBased::decompress(Buffer& buffer) const {
+MONGO_COMPILER_ALWAYS_INLINE_GCC14 void BSONColumnBlockBased::decompress(Buffer& buffer) const {
     const char* ptr = _binary;
     const char* end = _binary + _size;
     BSONType type = EOO;  // needs to be set as something else before deltas are parsed

src/mongo/bson/column/simple8b.h

@@ -369,11 +369,11 @@ inline size_t visitAll(const char* buffer,
                        const VisitMissing& visitMissing);
 
 template <typename T, typename Visit, typename VisitMissing>
-MONGO_COMPILER_ALWAYS_INLINE inline size_t visitAll(const char* buffer,
-                                                    size_t size,
-                                                    uint64_t& prevNonRLE,
-                                                    const Visit& visit,
-                                                    const VisitMissing& visitMissing) {
+MONGO_COMPILER_ALWAYS_INLINE_GCC14 inline size_t visitAll(const char* buffer,
+                                                          size_t size,
+                                                          uint64_t& prevNonRLE,
+                                                          const Visit& visit,
+                                                          const VisitMissing& visitMissing) {
     return visitAll<T>(buffer, size, prevNonRLE, visit, [&visit]() { visit(0); }, visitMissing);
 }
 

src/mongo/bson/column/simple8b.inl

@@ -795,11 +795,11 @@ T decodeLastSlot(uint64_t encoded) {
 
 // Decodes and visits all slots in simple8b block.
 template <typename T, typename Visit, typename VisitZero, typename VisitMissing>
-MONGO_COMPILER_ALWAYS_INLINE inline size_t decodeAndVisit(uint64_t encoded,
-                                                          uint64_t* prevNonRLE,
-                                                          const Visit& visit,
-                                                          const VisitZero& visitZero,
-                                                          const VisitMissing& visitMissing) {
+MONGO_COMPILER_ALWAYS_INLINE_GCC14 inline size_t decodeAndVisit(uint64_t encoded,
+                                                                uint64_t* prevNonRLE,
+                                                                const Visit& visit,
+                                                                const VisitZero& visitZero,
+                                                                const VisitMissing& visitMissing) {
     auto selector = encoded & simple8b_internal::kBaseSelectorMask;
     if (selector != simple8b_internal::kRleSelector) {
         *prevNonRLE = encoded;
@@ -1192,12 +1192,12 @@ T decodeAndPrefixSum(uint64_t encoded, T& prefix, uint64_t* prevNonRLE) {
 }  // namespace
 
 template <typename T, typename Visit, typename VisitZero, typename VisitMissing>
-MONGO_COMPILER_ALWAYS_INLINE size_t visitAll(const char* buffer,
-                                             size_t size,
-                                             uint64_t& prevNonRLE,
-                                             const Visit& visit,
-                                             const VisitZero& visitZero,
-                                             const VisitMissing& visitMissing) {
+MONGO_COMPILER_ALWAYS_INLINE_GCC14 size_t visitAll(const char* buffer,
+                                                   size_t size,
+                                                   uint64_t& prevNonRLE,
+                                                   const Visit& visit,
+                                                   const VisitZero& visitZero,
+                                                   const VisitMissing& visitMissing) {
     size_t numVisited = 0;
     invariant(size % 8 == 0);
     const char* end = buffer + size;

src/mongo/db/exec/sbe/values/ts_block.cpp

@@ -70,7 +70,7 @@ class BlockBasedDecompressAdaptor {
         _positions.reserve(expectedCount);
     }
 
-    MONGO_COMPILER_ALWAYS_INLINE void push_back(const Element& e) {
+    MONGO_COMPILER_ALWAYS_INLINE_GCC14 void push_back(const Element& e) {
         auto [tag, val] = e;
         _allValuesShallow = _allValuesShallow && value::isShallowType(tag);
         _tags.push_back(tag);

src/mongo/db/pipeline/percentile_algo_accurate.h

@@ -49,7 +49,7 @@ class AccuratePercentile : public PercentileAlgorithm, public PartialPercentile<
 public:
     AccuratePercentile() = default;  // no config required for this algorithm
 
-    MONGO_COMPILER_ALWAYS_INLINE void incorporate(double input) final {
+    MONGO_COMPILER_ALWAYS_INLINE_GCC14 void incorporate(double input) final {
         if (std::isnan(input)) {
             return;
         }

src/mongo/platform/compiler.h

@@ -164,6 +164,16 @@
 #define MONGO_COMPILER_ALWAYS_INLINE_
 #endif
 
+/**
+ * Force a function to be inlined as a temporary measure to buy-back performance regressions
+ * downstream of the switch to using the v5 toolchain.
+ * TODO(SERVER-105707): Reevaluate each use of this macro once we have enabled LTO/PGO and
+ * other post-compilation optimizations; for each, either delete the use or change it to use
+ * MONGO_COMPILER_ALWAYS_INLINE, committing the forced inlining choice permanently. Then delete
+ * this macro definition.
+ */
+#define MONGO_COMPILER_ALWAYS_INLINE_GCC14 MONGO_COMPILER_ALWAYS_INLINE
+
 /**
  * Tells the compiler that it can assume that this line will never execute.
  * Unlike with MONGO_UNREACHABLE, there is no runtime check and reaching this