fix: add validation for binary vector in Binary toXArray methods

Author: nbbeeken

src/binary.ts

@@ -341,6 +341,8 @@ export class Binary extends BSONValue {
       throw new BSONError('Binary datatype field is not Int8');
     }
 
+    validateBinaryVector(this);
+
     return new Int8Array(
       this.buffer.buffer.slice(this.buffer.byteOffset + 2, this.buffer.byteOffset + this.position)
     );
@@ -361,6 +363,8 @@ export class Binary extends BSONValue {
       throw new BSONError('Binary datatype field is not Float32');
     }
 
+    validateBinaryVector(this);
+
     const floatBytes = new Uint8Array(
       this.buffer.buffer.slice(this.buffer.byteOffset + 2, this.buffer.byteOffset + this.position)
     );
@@ -387,6 +391,8 @@ export class Binary extends BSONValue {
       throw new BSONError('Binary datatype field is not packed bit');
     }
 
+    validateBinaryVector(this);
+
     return new Uint8Array(
       this.buffer.buffer.slice(this.buffer.byteOffset + 2, this.buffer.byteOffset + this.position)
     );

test/node/bson_binary_vector.spec.test.ts

@@ -172,6 +172,21 @@ function testVectorInvalidBSONBytes(test: VectorTest, expectedErrorMessage: stri
       expect(thrownError?.message).to.match(new RegExp(expectedErrorMessage));
     });
 
+    const toHelper = dtypeToHelper(test.dtype_hex).replace('from', 'to');
+    it(`Binary.${toHelper}() throw a BSONError`, function () {
+      let thrownError: Error | undefined;
+      const bin = BSON.deserialize(Buffer.from(test.canonical_bson!, 'hex'));
+
+      try {
+        bin.vector[toHelper]();
+      } catch (error) {
+        thrownError = error;
+      }
+
+      expect(thrownError, thrownError?.stack).to.be.instanceOf(BSONError);
+      expect(thrownError?.message).to.match(new RegExp(expectedErrorMessage));
+    });
+
     it(`EJSON.stringify() throw a BSONError`, function () {
       let thrownError: Error | undefined;
       const bin = BSON.deserialize(Buffer.from(test.canonical_bson!, 'hex'));