Skip to content

Commit 1efbe56

Browse files
committed
fixes tests and coding standards
1 parent 181d417 commit 1efbe56

File tree

4 files changed

+16
-5
lines changed

4 files changed

+16
-5
lines changed

src/Event/Dispatcher/CollectingDispatcher.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,12 @@ public function __construct(DirectDispatcher $directDispatcher)
3333
public function dispatch(Event $event): void
3434
{
3535
$this->events->add($event);
36-
$this->isolatedDirectDispatcher->dispatch($event);
36+
try {
37+
$this->isolatedDirectDispatcher->dispatch($event);
38+
}
39+
catch (UnknownEventTypeException) {
40+
// Do nothing.
41+
}
3742
}
3843

3944
public function flush(): EventCollection

src/Runner/DeprecationCollector/Facade.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
*/
2323
final class Facade
2424
{
25-
private static Collector|InIsolationCollector|null $collector = null;
25+
private static null|Collector|InIsolationCollector $collector = null;
2626
private static bool $inIsolation = false;
2727

2828
/**

tests/end-to-end/generic/_files/TestForDeprecatedFeatureInIsolationTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,5 +81,4 @@ public function testExpectationOnDeprecationMessageMatchingRegularExpressionWork
8181

8282
@trigger_error('something else', E_USER_DEPRECATED);
8383
}
84-
8584
}

tests/unit/Event/Dispatcher/CollectingDispatcherTest.php

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,21 +12,28 @@
1212
use PHPUnit\Framework\Attributes\CoversClass;
1313
use PHPUnit\Framework\Attributes\Small;
1414
use PHPUnit\Framework\TestCase;
15+
use PHPUnit\Runner\DeprecationCollector\TestTriggeredDeprecationSubscriber;
1516

1617
#[CoversClass(CollectingDispatcher::class)]
1718
#[Small]
1819
final class CollectingDispatcherTest extends TestCase
1920
{
2021
public function testHasNoCollectedEventsWhenFlushedImmediatelyAfterCreation(): void
2122
{
22-
$dispatcher = new CollectingDispatcher;
23+
$typeMap = new TypeMap();
24+
$typeMap->addMapping(Test\DeprecationTriggeredSubscriber::class, Test\DeprecationTriggered::class);
25+
26+
$dispatcher = new CollectingDispatcher(new DirectDispatcher($typeMap));
2327

2428
$this->assertEmpty($dispatcher->flush());
2529
}
2630

2731
public function testCollectsDispatchedEventsUntilFlushed(): void
2832
{
29-
$dispatcher = new CollectingDispatcher;
33+
$typeMap = new TypeMap();
34+
$typeMap->addMapping(Test\DeprecationTriggeredSubscriber::class, Test\DeprecationTriggered::class);
35+
36+
$dispatcher = new CollectingDispatcher(new DirectDispatcher($typeMap));
3037
$event = $this->createStub(Event::class);
3138

3239
$dispatcher->dispatch($event);

0 commit comments

Comments
 (0)