Plugin doesn't detect recompiled files

[odrotbohm]

The Maven compiler plugin currently always recompiles sources, even if there have been any changes at all (see these tickets for details). That recompilation however is not recognized by the AspectJ Maven plugin and it just skips AspectJ compilation on subsequent runs.

To reproduce:

$ git clone https://github.com/spring-projects/spring-data-jpa
$ cd spring-data-jpa
$ mvn clean package -DskipTests
…
[INFO] --- maven-compiler-plugin:3.3:compile (default-compile) @ spring-data-jpa ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 101 source files to /Users/olivergierke/Documents/workspace/spring-data-jpa/target/classes
… 
[INFO] --- aspectj-maven-plugin:1.8:compile (default) @ spring-data-jpa ---
[INFO] Showing AJC message detail for messages of types: [error, warning, fail]
[WARNING] You aren't using a compiler supported by lombok, so lombok will not work and has been disabled.
Your processor is: org.aspectj.org.eclipse.jdt.internal.compiler.apt.dispatch.BatchProcessingEnvImpl
Lombok supports: sun/apple javac 1.6, ECJ
    <unknown source file>:<no line information>
[INFO]
$ mvn package -DskipTests
…
[INFO] --- maven-compiler-plugin:3.3:compile (default-compile) @ spring-data-jpa ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 101 source files to /Users/olivergierke/Documents/workspace/spring-data-jpa/target/classes
…
[INFO] --- aspectj-maven-plugin:1.8:compile (default) @ spring-data-jpa ---
[INFO] No modifications found skipping aspectJ compile
…

See the last line. The plugin skips the compilation step although the compiler plugin has recompiled the code and we end up with classes that haven't got any aspects applied.

[odrotbohm]

I currently work around this by setting the forceAjcCompile property to true.

[SunShineShine]

I tried to set forceAjcCompile property to true,but it still doesn't work,do you have any other way to solve the problem

[bmarwell]

@odrotbohm sorry for the late answer. Does it still apply?
I can write an integration test if needed.
The problem must be in these lines:

aspectj-maven-plugin/src/main/java/org/codehaus/mojo/aspectj/AbstractAjcCompiler.java

Lines 764 to 792 in a544b65

	private boolean hasSourcesChanged(File outDir) {
	long lastBuild = new File(outDir, argumentFileName).lastModified();
	for (String source : resolvedIncludes) {
	File sourceFile = new File(source);
	long sourceModified = sourceFile.lastModified();
	if (sourceModified >= lastBuild) {
	return true;
	}
	}
	return false;
	}
	private boolean hasNonWeavedClassesChanged(File outDir)
	throws MojoExecutionException {
	if (weaveDirectories != null && weaveDirectories.length > 0) {
	Set<String> weaveSources = AjcHelper.getWeaveSourceFiles(weaveDirectories);
	long lastBuild = new File(outDir, argumentFileName).lastModified();
	for (String source : weaveSources) {
	File sourceFile = new File(source);
	long sourceModified = sourceFile.lastModified();
	if (sourceModified >= lastBuild) {
	return true;
	}
	}
	}
	return false;
	}

I tried to set forceAjcCompile property to true,but it still doesn't work,do you have any other way to solve the problem

That is odd:

        if (!forceAjcCompile && !isBuildNeeded()) {
            getLog().info("No modifications found skipping aspectJ compile");
            return;
        }

[filnet]

Seeing the same issue with maven-aspectj-plugin 1.14.0 and maven-compiler-plugin 3.11.0.

[INFO] --- maven-compiler-plugin:3.11.0:compile (default-compile) @ project ---
[INFO] Changes detected - recompiling the module! :dependency
[INFO] Compiling 419 source files with javac [debug target 1.8] to target\classes
[INFO]
[INFO] --- aspectj-maven-plugin:1.14.0:compile (default) @ project ---
[INFO] No modifications found skipping aspectJ compile

Maven re-compiles the classes that need to be weaved but weaving does not happen.

The forceAjcCompile workaround works.

[kriegaex]

I cannot confirm that this happens. Neither does Maven Compiler always recompile all source files, nor do aspects not get applied after a recompile, at least not in a simple single-module test project:

$ mvn clean
(...)

$ mvn -Dmaven.compiler.showCompilationChanges compile

(...)
[INFO] --- compiler:3.11.0:compile (default-compile) @ my-application ---
[INFO] Stale source detected: ...\src\main\java\com\carrot\personal\app\SpecialApp.java
[INFO] Stale source detected: ...\src\main\java\com\carrot\personal\app\DataTrackHelper.java
[INFO] Stale source detected: ...\src\main\java\com\carrot\personal\aspects\DataTrackAspect.java
[INFO] Stale source detected: ...\src\main\java\com\carrot\personal\app\Application.java
[INFO] Stale source detected: ...\src\main\java\com\carrot\personal\aspects\DataTrackEnabled.java
[INFO] Changes detected - recompiling the module! :source
[INFO] 	+ ...\src\main\java\com\carrot\personal\app\SpecialApp.java
[INFO] 	+ ...\src\main\java\com\carrot\personal\aspects\DataTrackAspect.java
[INFO] 	+ ...\src\main\java\com\carrot\personal\app\DataTrackHelper.java
[INFO] 	+ ...\src\main\java\com\carrot\personal\aspects\DataTrackEnabled.java
[INFO] 	+ ...\src\main\java\com\carrot\personal\app\Application.java
[INFO] Compiling 5 source files with javac [debug target 11] to target\classes
[INFO] 
[INFO] --- aspectj:1.13.1:compile (default) @ my-application ---
[INFO] Showing AJC message detail for messages of types: [error, warning, fail]
[INFO] Join point 'method-execution(int Person.getId())' in Type 'Person' (NegatedTypeAspect.aj:41) advised by before advice from 'NegatedTypeAspect' (NegatedTypeAspect.aj:6)
[INFO] Join point 'method-execution(int Person.getId())' in Type 'Person' (NegatedTypeAspect.aj:41) advised by before advice from 'NegatedTypeAspect' (NegatedTypeAspect.aj:2)
[INFO] Join point 'method-execution(void Person.setId(int))' in Type 'Person' (NegatedTypeAspect.aj:45) advised by before advice from 'NegatedTypeAspect' (NegatedTypeAspect.aj:10)
[INFO] Join point 'method-execution(java.lang.String Person.getLastName())' in Type 'Person' (NegatedTypeAspect.aj:49) advised by before advice from 'NegatedTypeAspect' (NegatedTypeAspect.aj:2)
[INFO] Join point 'method-execution(void Person.setLastName(java.lang.String))' in Type 'Person' (NegatedTypeAspect.aj:53) advised by before advice from 'NegatedTypeAspect' (NegatedTypeAspect.aj:10)
[INFO] Join point 'method-execution(java.lang.String Person.getFirstName())' in Type 'Person' (NegatedTypeAspect.aj:57) advised by before advice from 'NegatedTypeAspect' (NegatedTypeAspect.aj:2)
[INFO] Join point 'method-execution(void Person.setFirstName(java.lang.String))' in Type 'Person' (NegatedTypeAspect.aj:61) advised by before advice from 'NegatedTypeAspect' (NegatedTypeAspect.aj:10)
[INFO] Join point 'method-execution(void Person.setFullName(java.lang.String))' in Type 'Person' (NegatedTypeAspect.aj:73) advised by before advice from 'NegatedTypeAspect' (NegatedTypeAspect.aj:10)
[INFO] Join point 'method-execution(void Person.getVoid())' in Type 'Person' (NegatedTypeAspect.aj:90) advised by before advice from 'NegatedTypeAspect' (NegatedTypeAspect.aj:6)
[INFO] Join point 'method-execution(java.lang.String com.carrot.personal.app.Application$User.getFirstName())' in Type 'com.carrot.personal.app.Application$User' (Application.java:41) advised by before advice from 'NegatedTypeAspect' (NegatedTypeAspect.aj:2)
[INFO] Join point 'method-execution(java.lang.String com.carrot.personal.app.Application$User.getLastName())' in Type 'com.carrot.personal.app.Application$User' (Application.java:45) advised by before advice from 'NegatedTypeAspect' (NegatedTypeAspect.aj:2)
[INFO] Join point 'method-execution(java.util.Map com.carrot.personal.app.Application.fetchUser())' in Type 'com.carrot.personal.app.Application' (Application.java:33) advised by around advice from 'com.carrot.personal.aspects.DataTrackAspect' (DataTrackAspect.java:11)
(...)

$ mvn -Dmaven.compiler.showCompilationChanges compile

(...)
[INFO] --- compiler:3.11.0:compile (default-compile) @ my-application ---
[INFO] Nothing to compile - all classes are up to date
[INFO] 
[INFO] --- aspectj:1.13.1:compile (default) @ my-application ---
[INFO] No modifications found skipping aspectJ compile
(...)

A minimal reproducer project would be helpful.

BTW, is there anything keeping you from simply deactivating Maven Compiler completely in the modules using AspectJ Maven? AJC is based on ECJ and therefore a full replacement for Javac. Then you would not have this problem in the first place. I am talking about adding something like this:

<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-compiler-plugin</artifactId>
  <version>3.11.0</version>
  <executions>
    <execution>
      <id>default-compile</id>
      <phase>none</phase>
    </execution>
    <execution>
      <id>default-testCompile</id>
      <phase>none</phase>
    </execution>
  </executions>
  <configuration>
    <source>11</source>
    <target>11</target>
  </configuration>
</plugin>

Of course, if there really was a problem is AJ Maven, this would just be a workaround and we should still investigate the original problem, but for that a reproducer is necessary.

[filnet]

I think you need two projects:

• a plain jar project
• a second project that depends on the 1st project and uses AJ.

If you change the 1st project, the 2nd project will be recompiled too because one of its dependencies changed.

You'll see such a message for the second project:
[INFO] Changes detected - recompiling the module! :dependency
When that happens the 2nd project gets compiled but no AJ.

[EDIT] I am seeing the issue with Maven 3.8.3.

[kriegaex]

Sorry @filnet, but when I use a separate project and mvn install it, my dependent Maven project does not recompile anything. Even if in the dependency I change a method signature in a way that would make the dependent project fail on recompile, no change in the dependency is picked up and Maven Compiler 3.11.0 does absolutely nothing:

[INFO] --- compiler:3.11.0:compile (default-compile) @ my-application ---
[INFO] Nothing to compile - all classes are up to date

Only if instead of mvn compile I use mvn clean compile, will it detect the dependency change and throw an error during compilation.

So, if this does not even work in Maven Compiler, how is AspectJ Maven expected to react on the dependency change?

If it is so easy to reproduce, where is the MCVE? I do not want to keep guessing and using trial & error to reproduce it, before I can even think about analysing and fixing it.

[filnet]

@kriegaex, I made a small project that reproduces the issue : https://github.com/filnet/maven-aspectj-plugin-issue

Steps to reproduce:

• Compile the project with mvn compile from the root of the project.
• Edit the file ./project1/src/main/java/BaseModel.java
• Compile the project again (again from the root of the project).

You should see that project2 is recompiled because maven detected that its dependency project1 has changed.
The ./project2/src/main/java/Model.java file gets recompiled but not weaved.

This is the output I get for project2:

[INFO] --------------------------< project:project2 >--------------------------
[INFO] Building project2 1.0.0                                            [4/4]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-resources-plugin:3.3.1:resources (default-resources) @ project2 ---
[INFO] skip non existing resourceDirectory C:\bug\project2\src\main\resources
[INFO]
[INFO] --- maven-compiler-plugin:3.11.0:compile (default-compile) @ project2 ---
[INFO] New dependency detected: C:\bug\project1\target\classes
[INFO] Changes detected - recompiling the module! :dependency
[INFO] Compiling 1 source file with javac [debug target 1.8] to target\classes
[INFO]
[INFO] --- aspectj-maven-plugin:1.14.0:compile (default) @ project2 ---
[INFO] No modifications found skipping aspectJ compile

[kriegaex]

I think you need two projects:

• a plain jar project
• a second project that depends on the 1st project and uses AJ.

I made a small project that reproduces the issue : https://github.com/filnet/maven-aspectj-plugin-issue

Yeah, now we are getting there. So the problem is not two projects but rather one multi-module project where module B depends on module A and there are undetected changes in A when building B.

Unfortunately, this is not so much a bug, but rather a total lack of functionality in AJ Maven. The plugin simply does not check at all if there have been changes in any dependency class file directories or JARs in the same project.