Skip to content

fix stuck insert by binding buffer and chan to ensure proper notification #42505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

tinswzy
Copy link
Contributor

@tinswzy tinswzy commented Jun 4, 2025

#41918 #42482 #42049 #42513

cherrypick: sn release memory after pop from heap
wp: Encapsulate buffer and chan into a single item for one-to-one management and cleanup

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. area/dependency Pull requests that update a dependency file labels Jun 4, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Jun 4, 2025
Copy link
Contributor

mergify bot commented Jun 4, 2025

@tinswzy

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.54%. Comparing base (c5adc09) to head (60d5c32).
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #42505       +/-   ##
===========================================
+ Coverage   73.01%   80.54%    +7.52%     
===========================================
  Files         335     1541     +1206     
  Lines       30965   219220   +188255     
===========================================
+ Hits        22609   176566   +153957     
- Misses       8356    36301    +27945     
- Partials        0     6353     +6353     
Components Coverage Δ
Client 79.36% <ø> (∅)
Core 72.66% <ø> (-0.35%) ⬇️
Go 82.07% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/streamingcoord/server/broadcaster/task.go 100.00% <100.00%> (ø)
...ngnode/server/wal/interceptors/timetick/ack/ack.go 93.93% <100.00%> (ø)
...er/wal/interceptors/timetick/ack/last_confirmed.go 100.00% <100.00%> (ø)
...l/streamingnode/server/wal/utility/message_heap.go 100.00% <100.00%> (ø)
pkg/util/typeutil/heap.go 93.54% <100.00%> (ø)

... and 1220 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tinswzy tinswzy force-pushed the enhance_wp_sync branch from ddcebb7 to 4ccb788 Compare June 4, 2025 06:09
Copy link
Collaborator

@czs007 czs007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, tinswzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jun 4, 2025

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jun 4, 2025

@tinswzy cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@tinswzy tinswzy force-pushed the enhance_wp_sync branch 2 times, most recently from 237daa1 to 7561059 Compare June 4, 2025 12:09
@tinswzy tinswzy force-pushed the enhance_wp_sync branch from 7561059 to 60d5c32 Compare June 4, 2025 13:00
Copy link
Contributor

mergify bot commented Jun 4, 2025

@tinswzy cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@tinswzy
Copy link
Contributor Author

tinswzy commented Jun 4, 2025

rerun cpp-unit-test

@mergify mergify bot added the ci-passed label Jun 4, 2025
@czs007
Copy link
Collaborator

czs007 commented Jun 5, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit 74432db into milvus-io:master Jun 5, 2025
19 of 20 checks passed
jfwm2 pushed a commit to jfwm2/milvus that referenced this pull request Jun 8, 2025
…tion (milvus-io#42505)

milvus-io#41918 milvus-io#42482  milvus-io#42049  milvus-io#42513 

cherrypick: sn release memory after pop from heap 
wp: Encapsulate buffer and chan into a single item for one-to-one
management and cleanup

Signed-off-by: tinswzy <[email protected]>
Co-authored-by: chyezh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. do-not-merge/invalid-pr-format lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants