-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix stuck insert by binding buffer and chan to ensure proper notification #42505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #42505 +/- ##
===========================================
+ Coverage 73.01% 80.54% +7.52%
===========================================
Files 335 1541 +1206
Lines 30965 219220 +188255
===========================================
+ Hits 22609 176566 +153957
- Misses 8356 36301 +27945
- Partials 0 6353 +6353
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, tinswzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tinswzy E2e jenkins job failed, comment |
@tinswzy cpp-unit-test check failed, comment |
237daa1
to
7561059
Compare
…tion Signed-off-by: tinswzy <[email protected]>
@tinswzy cpp-unit-test check failed, comment |
rerun cpp-unit-test |
/lgtm |
…tion (milvus-io#42505) milvus-io#41918 milvus-io#42482 milvus-io#42049 milvus-io#42513 cherrypick: sn release memory after pop from heap wp: Encapsulate buffer and chan into a single item for one-to-one management and cleanup Signed-off-by: tinswzy <[email protected]> Co-authored-by: chyezh <[email protected]>
#41918 #42482 #42049 #42513
cherrypick: sn release memory after pop from heap
wp: Encapsulate buffer and chan into a single item for one-to-one management and cleanup