change crc config to ture

- fix the coding style of cpp
- align the config file with the paramtable code

Signed-off-by: yangxuan <xuan.yang@zilliz.com>

Author: XuanYang-cn

configs/milvus.yaml

@@ -124,7 +124,7 @@ minio:
     # We recommend using version 1.2 and above.
     tlsMinVersion: default
     # Whether to use CRC32C checksum for data integrity validation on MinIO/S3 PutObject requests.
-    useCRC32C: false
+    useCRC32C: true
   # Name of the bucket where Milvus stores data in MinIO or S3.
   # Milvus 2.0.0 does not support storing data in multiple buckets.
   # Bucket with this name will be created if it does not exist. If the bucket already exists and is accessible, it will be used directly. Otherwise, there will be an error.

internal/core/src/storage/ChunkManager.cpp

@@ -82,8 +82,7 @@ AwsChunkManager::AwsChunkManager(const StorageConfig& storage_config) {
     remote_root_path_ = storage_config.root_path;
     use_crc32c_checksum_ = storage_config.use_crc32c_checksum;
 
-    InitSDKAPIDefault(storage_config.log_level,
-                      storage_config.tls_min_version);
+    InitSDKAPIDefault(storage_config.log_level, storage_config.tls_min_version);
 
     Aws::Client::ClientConfiguration config = generateConfig(storage_config);
     if (storage_config.useIAM) {
@@ -136,8 +135,7 @@ GcpChunkManager::GcpChunkManager(const StorageConfig& storage_config) {
         };
     }
 
-    InitSDKAPIDefault(storage_config.log_level,
-                      storage_config.tls_min_version);
+    InitSDKAPIDefault(storage_config.log_level, storage_config.tls_min_version);
 
     Aws::Client::ClientConfiguration config = generateConfig(storage_config);
     if (storage_config.useIAM) {
@@ -170,8 +168,7 @@ AliyunChunkManager::AliyunChunkManager(const StorageConfig& storage_config) {
     remote_root_path_ = storage_config.root_path;
     use_crc32c_checksum_ = storage_config.use_crc32c_checksum;
 
-    InitSDKAPIDefault(storage_config.log_level,
-                      storage_config.tls_min_version);
+    InitSDKAPIDefault(storage_config.log_level, storage_config.tls_min_version);
 
     Aws::Client::ClientConfiguration config = generateConfig(storage_config);
 
@@ -218,8 +215,7 @@ TencentCloudChunkManager::TencentCloudChunkManager(
     remote_root_path_ = storage_config.root_path;
     use_crc32c_checksum_ = storage_config.use_crc32c_checksum;
 
-    InitSDKAPIDefault(storage_config.log_level,
-                      storage_config.tls_min_version);
+    InitSDKAPIDefault(storage_config.log_level, storage_config.tls_min_version);
 
     Aws::Client::ClientConfiguration config = generateConfig(storage_config);
 
@@ -265,8 +261,7 @@ HuaweiCloudChunkManager::HuaweiCloudChunkManager(
     default_bucket_name_ = storage_config.bucket_name;
     remote_root_path_ = storage_config.root_path;
     use_crc32c_checksum_ = storage_config.use_crc32c_checksum;
-    InitSDKAPIDefault(storage_config.log_level,
-                      storage_config.tls_min_version);
+    InitSDKAPIDefault(storage_config.log_level, storage_config.tls_min_version);
     Aws::Client::ClientConfiguration config = generateConfig(storage_config);
     StorageConfig mutable_config = storage_config;
     mutable_config.useVirtualHost = true;

internal/core/src/storage/MinioChunkManager.cpp

@@ -607,8 +607,7 @@ MinioChunkManager::PutObjectBuffer(const std::string& bucket_name,
     request.SetBucket(bucket_name.c_str());
     request.SetKey(object_name.c_str());
     if (use_crc32c_checksum_) {
-        request.SetChecksumAlgorithm(
-            Aws::S3::Model::ChecksumAlgorithm::CRC32C);
+        request.SetChecksumAlgorithm(Aws::S3::Model::ChecksumAlgorithm::CRC32C);
     }
 
     const std::shared_ptr<Aws::IOStream> input_data =

internal/core/src/storage/MinioChunkManager.h

@@ -353,8 +353,8 @@ class TlsHttpClientFactory : public Aws::Http::HttpClientFactory {
     }
 
     std::shared_ptr<Aws::Http::HttpClient>
-    CreateHttpClient(const Aws::Client::ClientConfiguration& config)
-        const override {
+    CreateHttpClient(
+        const Aws::Client::ClientConfiguration& config) const override {
         return Aws::MakeShared<TlsCurlHttpClient>(
             TLS_FACTORY_ALLOCATION_TAG, config, tls_min_version_);
     }

internal/core/src/storage/Types.h

@@ -123,8 +123,8 @@ struct StorageConfig {
            << ", maxConnections=" << max_connections
            << ", gcp_native_without_auth=" << std::boolalpha
            << gcp_native_without_auth << ", tls_min_version=" << tls_min_version
-           << ", use_crc32c_checksum=" << std::boolalpha
-           << use_crc32c_checksum << "]";
+           << ", use_crc32c_checksum=" << std::boolalpha << use_crc32c_checksum
+           << "]";
 
         return ss.str();
     }

pkg/util/paramtable/service_param.go

@@ -1630,7 +1630,7 @@ Leave it empty if you want to use AWS default endpoint`,
 	p.UseCRC32C = ParamItem{
 		Key:          "minio.ssl.useCRC32C",
 		Version:      "2.6.11",
-		DefaultValue: "false",
+		DefaultValue: "true",
 		Doc:          "Whether to use CRC32C checksum for data integrity validation on MinIO/S3 PutObject requests.",
 		Export:       true,
 	}