refactor: use slices.Contains and slices.ContainsFunc to simplify code

Signed-off-by: tongjicoder <[email protected]>

Author: tongjicoder

internal/ast/ast.go

@@ -2,6 +2,7 @@ package ast
 
 import (
 	"fmt"
+	"slices"
 	"strings"
 	"sync"
 	"sync/atomic"
@@ -22,12 +23,7 @@ func visit(v Visitor, node *Node) bool {
 }
 
 func visitNodes(v Visitor, nodes []*Node) bool {
-	for _, node := range nodes {
-		if v(node) {
-			return true
-		}
-	}
-	return false
+	return slices.ContainsFunc(nodes, v)
 }
 
 func visitNodeList(v Visitor, nodeList *NodeList) bool {

internal/binder/binder.go

@@ -2666,10 +2666,8 @@ func isNarrowableReference(node *ast.Node) bool {
 
 func hasNarrowableArgument(expr *ast.Node) bool {
 	call := expr.AsCallExpression()
-	for _, argument := range call.Arguments.Nodes {
-		if containsNarrowableReference(argument) {
-			return true
-		}
+	if slices.ContainsFunc(call.Arguments.Nodes, containsNarrowableReference) {
+		return true
 	}
 	if ast.IsPropertyAccessExpression(call.Expression) {
 		if containsNarrowableReference(call.Expression.AsPropertyAccessExpression().Expression) {

internal/checker/grammarchecks.go

@@ -2,6 +2,7 @@ package checker
 
 import (
 	"fmt"
+	"slices"
 	"strings"
 
 	"github.com/microsoft/typescript-go/internal/ast"
@@ -887,12 +888,7 @@ func (c *Checker) checkGrammarHeritageClause(node *ast.HeritageClause) bool {
 		return c.grammarErrorAtPos(node.AsNode(), types.Pos(), 0, diagnostics.X_0_list_cannot_be_empty, listType)
 	}
 
-	for _, node := range types.Nodes {
-		if c.checkGrammarExpressionWithTypeArguments(node) {
-			return true
-		}
-	}
-	return false
+	return slices.ContainsFunc(types.Nodes, c.checkGrammarExpressionWithTypeArguments)
 }
 
 func (c *Checker) checkGrammarExpressionWithTypeArguments(node *ast.Node /*Union[ExpressionWithTypeArguments, TypeQueryNode]*/) bool {

internal/checker/mapper.go

@@ -1,6 +1,10 @@
 package checker
 
-import "github.com/microsoft/typescript-go/internal/core"
+import (
+	"slices"
+
+	"github.com/microsoft/typescript-go/internal/core"
+)
 
 // TypeMapperKind
 
@@ -158,10 +162,8 @@ func newArrayToSingleTypeMapper(sources []*Type, target *Type) *TypeMapper {
 }
 
 func (m *ArrayToSingleTypeMapper) Map(t *Type) *Type {
-	for _, s := range m.sources {
-		if t == s {
-			return m.target
-		}
+	if slices.Contains(m.sources, t) {
+		return m.target
 	}
 	return t
 }

internal/core/core.go

@@ -135,12 +135,7 @@ func Same[T any](s1 []T, s2 []T) bool {
 }
 
 func Some[T any](slice []T, f func(T) bool) bool {
-	for _, value := range slice {
-		if f(value) {
-			return true
-		}
-	}
-	return false
+	return slices.ContainsFunc(slice, f)
 }
 
 func Every[T any](slice []T, f func(T) bool) bool {