Fix GetElementOrPropertyAccessName to handle ElementAccessExpression correctly

Co-authored-by: jakebailey <[email protected]>

Author: Copilot

internal/ast/elementaccess_test.go

@@ -0,0 +1,37 @@
+package ast
+
+import (
+	"testing"
+)
+
+func TestGetElementOrPropertyAccessName(t *testing.T) {
+	factory := NewNodeFactory(NodeFactoryHooks{})
+	
+	// Test with a string literal argument
+	stringLiteral := factory.NewStringLiteral("key")
+	expression := factory.NewIdentifier("obj")
+	elementAccess := factory.NewElementAccessExpression(expression, nil, stringLiteral, 0)
+	
+	name := GetElementOrPropertyAccessName(elementAccess)
+	if name != "key" {
+		t.Errorf("Expected GetElementOrPropertyAccessName to return 'key', got '%s'", name)
+	}
+	
+	// Test with a numeric literal argument
+	numericLiteral := factory.NewNumericLiteral("123")
+	elementAccess = factory.NewElementAccessExpression(expression, nil, numericLiteral, 0)
+	
+	name = GetElementOrPropertyAccessName(elementAccess)
+	if name != "123" {
+		t.Errorf("Expected GetElementOrPropertyAccessName to return '123', got '%s'", name)
+	}
+	
+	// Test with a non-literal argument
+	nonLiteralArg := factory.NewIdentifier("nonLiteralKey")
+	elementAccess = factory.NewElementAccessExpression(expression, nil, nonLiteralArg, 0)
+	
+	name = GetElementOrPropertyAccessName(elementAccess)
+	if name != "" {
+		t.Errorf("Expected GetElementOrPropertyAccessName to return '', got '%s'", name)
+	}
+}

internal/ast/utilities.go

@@ -1301,7 +1301,7 @@ func GetElementOrPropertyAccessArgumentExpressionOrName(node *Node) *Node {
 		if IsStringOrNumericLiteralLike(arg) {
 			return arg
 		}
-		return nil
+		return node
 	}
 	panic("Unhandled case in GetElementOrPropertyAccessArgumentExpressionOrName")
 }
@@ -1311,6 +1311,11 @@ func GetElementOrPropertyAccessName(node *Node) string {
 	if name == nil {
 		return ""
 	}
+	// If we get back the original node and it's an ElementAccessExpression,
+	// it means it had a non-literal argument, so return empty string
+	if name == node && node.Kind == KindElementAccessExpression {
+		return ""
+	}
 	return name.Text()
 }