Ensure globs are always sorted (#1027)

Author: jakebailey

internal/project/service_test.go

@@ -543,19 +543,19 @@ func TestService(t *testing.T) {
 				{
 					Kind: ptrTo(lsproto.WatchKindCreate | lsproto.WatchKindChange | lsproto.WatchKindDelete),
 					GlobPattern: lsproto.GlobPattern{
-						Pattern: ptrTo("/home/projects/TS/p1/tsconfig.json"),
+						Pattern: ptrTo("/home/projects/TS/p1/src/index.ts"),
 					},
 				},
 				{
 					Kind: ptrTo(lsproto.WatchKindCreate | lsproto.WatchKindChange | lsproto.WatchKindDelete),
 					GlobPattern: lsproto.GlobPattern{
-						Pattern: ptrTo("/home/projects/TS/p1/src/index.ts"),
+						Pattern: ptrTo("/home/projects/TS/p1/src/y.ts"),
 					},
 				},
 				{
 					Kind: ptrTo(lsproto.WatchKindCreate | lsproto.WatchKindChange | lsproto.WatchKindDelete),
 					GlobPattern: lsproto.GlobPattern{
-						Pattern: ptrTo("/home/projects/TS/p1/src/y.ts"),
+						Pattern: ptrTo("/home/projects/TS/p1/tsconfig.json"),
 					},
 				},
 			})

internal/project/watch.go

@@ -53,6 +53,9 @@ func (w *watchedFiles[T]) update(ctx context.Context, newData T) {
 
 func (w *watchedFiles[T]) updateWorker(ctx context.Context, newData T) (updated bool, err error) {
 	newGlobs := w.getGlobs(newData)
+	newGlobs = slices.Clone(newGlobs)
+	slices.Sort(newGlobs)
+
 	w.data = newData
 	if slices.Equal(w.globs, newGlobs) {
 		return false, nil
@@ -88,7 +91,7 @@ func (w *watchedFiles[T]) updateWorker(ctx context.Context, newData T) (updated
 }
 
 func globMapperForTypingsInstaller(data map[tspath.Path]string) []string {
-	return slices.Sorted(maps.Values(data))
+	return slices.AppendSeq(make([]string, 0, len(data)), maps.Values(data))
 }
 
 func createResolutionLookupGlobMapper(host ProjectHost) func(data map[tspath.Path]string) []string {
@@ -136,7 +139,6 @@ func createResolutionLookupGlobMapper(host ProjectHost) func(data map[tspath.Pat
 				globs = append(globs, dir+"/"+fileGlobPattern)
 			}
 		}
-		slices.Sort(globs)
 
 		timeTaken := time.Since(start)
 		host.Log(fmt.Sprintf("createGlobMapper took %s to create %d globs for %d failed lookups", timeTaken, len(globs), len(data)))