Refactoring tests (#217)

Author: carusogabriel

tests/ParserGrammarTest.php

@@ -100,7 +100,7 @@ public function testSpecOutputTreeClassificationAndLength($testCaseFile, $expect
         $tokens = str_replace("\r\n", "\n", json_encode($sourceFile, JSON_PRETTY_PRINT));
         file_put_contents($expectedTreeFile, $tokens);
 
-        $this->assertEquals(0, count(DiagnosticsProvider::getDiagnostics($sourceFile)));
+        $this->assertCount(0, DiagnosticsProvider::getDiagnostics($sourceFile));
     }
 
     public function outTreeProvider() {

tests/api/getResolvedName.php

@@ -82,7 +82,7 @@ public function dataProvider() {
      */
     public function testGetResolvedName($contents, $expectedName) {
         $node = $this->getNodeAtPosition($contents);
-        $this->assertTrue($node instanceof Node\QualifiedName, "Node is not QualifiedName: " . get_class($node));
+        $this->assertInstanceOf(Node\QualifiedName::class, $node);
 
         $name = $node->getResolvedName();
         $this->assertEquals($expectedName, (string)$name);
@@ -91,7 +91,7 @@ public function testGetResolvedName($contents, $expectedName) {
     private function getNodeAtPosition($contents): Node {
         $parser = new Parser();
         $pos = strpos($contents, '_');
-        $this->assertTrue($pos != FALSE, 'Data is missing underscore');
+        $this->assertNotFalse($pos, 'Data is missing underscore');
         $contents = str_replace('_', '', $contents);
 
         $node = $parser->parseSourceFile($contents);