Merge pull request #216 from carusogabriel/early-return

roblourens · web-flow · commit 0e936a121f8a · 2017-12-13T09:35:19.000-08:00
Apply Early Return
diff --git a/src/Node.php b/src/Node.php
@@ -48,11 +48,10 @@ public function getFullStart() : int {
         foreach($this::CHILD_NAMES as $name) {
             if (($child = $this->$name) !== null) {
                 if (\is_array($child)) {
-                    if (isset($child[0])) {
-                        $child = $child[0];
-                    } else {
+                    if(!isset($child[0])) {
                         continue;
                     }
+                    $child = $child[0];
                 }
                 if ($child instanceof Node) {
                     return $child->getFullStart();

Original file line number	Diff line number	Diff line change
`@@ -48,11 +48,10 @@ public function getFullStart() : int {`
`48`	`48`	`foreach($this::CHILD_NAMES as $name) {`
`49`	`49`	`if (($child = $this->$name) !== null) {`
`50`	`50`	`if (\is_array($child)) {`
`51`		`- if (isset($child[0])) {`
`52`		`- $child = $child[0];`
`53`		`- } else {`
	`51`	`+ if(!isset($child[0])) {`
`54`	`52`	`continue;`
`55`	`53`	`}`
	`54`	`+ $child = $child[0];`
`56`	`55`	`}`
`57`	`56`	`if ($child instanceof Node) {`
`58`	`57`	`return $child->getFullStart();`