Right click paste also does a copy with copyOnSelect

[csdivad]

Windows Terminal version

1.23.20211.0

Windows build number

10.0.26100.7840

Other Software

No response

Steps to reproduce

1. Set copyOnSelect to true.
2. Open a shell in Terminal (PowerShell for example).
3. Select a text in that shell to copy it. Don't click into the window afterwards to ensure the selection remains.
4. Switch to another application (notepad recommended for the next step). The selected text should remain selected.
5. Test that the selected text is on the clipboard and then overwrite it by copying some other text.
6. Switch back to the terminal with alt+tab and do a paste with right click. Or just right click into the Terminal text area which also brings the window into focus and performs a paste in one go.

Expected Behavior

The new text from step 4 is pasted.
The old selected text should not be copied by right clicking.

Actual Behavior

The already selected text gets copied to the clipboard again before the paste happens. So the text from step 3 is pasted.

Same thing can happen when switching between Terminal tabs without clearing the selection first.
So it seems that right click copies an already selected text first.

[csdivad]

Keep in mind, that when copyOnSelect is false it should still require that right click for the actual copy to happen. But that also clears the selection, so it is not going to cause further issues.

[sagarbhure-msft]

I've opened a PR to fix this: #19943

The root cause is in ControlInteractivity::PointerPressed - the right-click handler unconditionally calls CopySelectionToClipboard() before pasting, even when copyOnSelect is enabled and the selection was already copied on mouse-up. This overwrites the current clipboard contents with the stale visible selection.

[sagarbhure-msft]

Can I get some 👀 on this one please, thanks!

[zadjii-msft]

Oh hey look, the old PR I had for this (many years ago)
#14635

original thread is: #14464

[DHowett]

Looks like a duplicate of #14464!