Skip to content

Commit ece2ef7

Browse files
zadjii-msftDHowett
authored andcommitted
Remove the animations from the suggestions UI (#17247)
gotta go fast, and these animations are not fast noted in #15845 (cherry picked from commit 46526bc) Service-Card-Id: 92546875 Service-Version: 1.21
1 parent ef283da commit ece2ef7

File tree

1 file changed

+21
-1
lines changed

1 file changed

+21
-1
lines changed

src/cascadia/TerminalApp/SuggestionsControl.xaml

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
xmlns:model="using:Microsoft.Terminal.Settings.Model"
1313
xmlns:mtu="using:Microsoft.Terminal.UI"
1414
xmlns:mux="using:Microsoft.UI.Xaml.Controls"
15+
MinWidth="256"
1516
AllowFocusOnInteraction="True"
1617
AutomationProperties.Name="{x:Bind ControlName, Mode=OneWay}"
1718
IsTabStop="True"
@@ -99,6 +100,24 @@
99100
GeneralItemTemplate="{StaticResource GeneralItemTemplate}"
100101
NestedItemTemplate="{StaticResource NestedItemTemplate}" />
101102

103+
<!--
104+
Remove all item animations from the suggestions UI. They're
105+
entirely too slow to let that UI be usable.
106+
-->
107+
<Style x:Key="NoAnimationsPlease"
108+
TargetType="ListView">
109+
<Setter Property="ItemContainerTransitions">
110+
<Setter.Value>
111+
<TransitionCollection>
112+
<!-- (deleted transitions are left for reference for what we removed) -->
113+
<ContentThemeTransition />
114+
<!--<AddDeleteThemeTransition/>-->
115+
<!--<ReorderThemeTransition/>-->
116+
<!--<EntranceThemeTransition IsStaggeringEnabled="False"/>-->
117+
</TransitionCollection>
118+
</Setter.Value>
119+
</Setter>
120+
</Style>
102121
</ResourceDictionary>
103122
</UserControl.Resources>
104123

@@ -203,7 +222,8 @@
203222
ItemClick="_listItemClicked"
204223
ItemsSource="{x:Bind FilteredActions}"
205224
SelectionChanged="_listItemSelectionChanged"
206-
SelectionMode="Single" />
225+
SelectionMode="Single"
226+
Style="{StaticResource NoAnimationsPlease}" />
207227

208228
</Grid>
209229

0 commit comments

Comments
 (0)