Improve refactorability of other projects' tests.

Author: iclanton

apps/api-extractor/src/analyzer/test/PackageMetadataManager.test.ts

@@ -30,8 +30,8 @@ function firstArgument(mockFn: jest.Mock): any {
 
 /* eslint-disable @typescript-eslint/typedef */
 
-describe('PackageMetadataManager', () => {
-  describe('.writeTsdocMetadataFile()', () => {
+describe(PackageMetadataManager.name, () => {
+  describe(PackageMetadataManager.writeTsdocMetadataFile.name, () => {
     const originalWriteFile = FileSystem.writeFile;
     const mockWriteFile: jest.Mock = jest.fn();
     beforeAll(() => {
@@ -50,7 +50,7 @@ describe('PackageMetadataManager', () => {
     });
   });
 
-  describe('.resolveTsdocMetadataPath()', () => {
+  describe(PackageMetadataManager.resolveTsdocMetadataPath.name, () => {
     describe('when an empty tsdocMetadataPath is provided', () => {
       const tsdocMetadataPath: string = '';
       describe('given a package.json where the field "tsdocMetadata" is defined', () => {

apps/api-extractor/src/analyzer/test/SyntaxHelpers.test.ts

@@ -3,8 +3,8 @@
 
 import { SyntaxHelpers } from '../SyntaxHelpers';
 
-describe('SyntaxHelpers', () => {
-  test('.toAlphaNumericCamelCase()', () => {
+describe(SyntaxHelpers.name, () => {
+  it(SyntaxHelpers.makeCamelCaseIdentifier.name, () => {
     // prettier-ignore
     const inputs:string[] = [
       '',

apps/api-extractor/src/api/test/ExtractorConfig-lookup.test.ts

@@ -15,7 +15,7 @@ function expectEqualPaths(path1: string, path2: string): void {
 }
 
 // Tests for expanding the "<lookup>" token for the "projectFolder" setting in api-extractor.json
-describe('ExtractorConfig-lookup', () => {
+describe(`${ExtractorConfig.name}.${ExtractorConfig.loadFileAndPrepare.name}`, () => {
   it.only('config-lookup1: looks up ./api-extractor.json', () => {
     const extractorConfig: ExtractorConfig = ExtractorConfig.loadFileAndPrepare(
       path.join(testDataFolder, 'config-lookup1/api-extractor.json')

apps/heft/src/pluginFramework/logging/test/FileError.test.ts

@@ -3,7 +3,7 @@
 
 import { FileError, FileErrorFormat } from '../FileError';
 
-describe('FileError', () => {
+describe(FileError.name, () => {
   it('normalizes slashes in file paths', () => {
     const error1: FileError = new FileError('message', 'path\\to\\file', 0);
     expect(error1.filePath).toEqual('path/to/file');

apps/heft/src/utilities/subprocess/test/SubprocessRunnerBase.test.ts

@@ -4,7 +4,7 @@
 import { SubprocessRunnerBase } from '../SubprocessRunnerBase';
 import { FileError } from '../../../pluginFramework/logging/FileError';
 
-describe('SubprocessRunnerBase', () => {
+describe(SubprocessRunnerBase.name, () => {
   it(`${SubprocessRunnerBase.serializeForIpcMessage.name} correctly serializes objects`, () => {
     expect(SubprocessRunnerBase.serializeForIpcMessage(1)).toMatchSnapshot();
     expect(SubprocessRunnerBase.serializeForIpcMessage(false)).toMatchSnapshot();

apps/rush-lib/src/cli/actions/test/AddAction.test.ts

@@ -8,7 +8,7 @@ import { RushCommandLineParser } from '../../RushCommandLineParser';
 import { AddAction } from '../AddAction';
 
 describe(AddAction.name, () => {
-  describe(`basic "rush add" tests`, () => {
+  describe('basic "rush add" tests', () => {
     let doRushAddMock: jest.SpyInstance;
     let oldExitCode: number | undefined;
     let oldArgs: string[];
@@ -28,7 +28,7 @@ describe(AddAction.name, () => {
       process.argv = oldArgs;
     });
 
-    describe(`'add' action`, () => {
+    describe("'add' action", () => {
       it(`adds a dependency to just one repo in the workspace`, async () => {
         const startPath: string = `${__dirname}/addRepo`;
         const aPath: string = `${__dirname}/addRepo/a`;
@@ -53,7 +53,7 @@ describe(AddAction.name, () => {
       });
     });
 
-    describe(`'add' action with --all`, () => {
+    describe("'add' action with --all", () => {
       it(`adds a dependency to all repos in the workspace`, async () => {
         const startPath: string = `${__dirname}/addRepo`;
         const aPath: string = `${__dirname}/addRepo/a`;

apps/rush-lib/src/cli/test/RushCommandLineParser.test.ts

@@ -92,7 +92,7 @@ describe(RushCommandLineParser.name, () => {
     });
 
     describe('in basic repo', () => {
-      describe(`'build' action`, () => {
+      describe("'build' action", () => {
         it(`executes the package's 'build' script`, async () => {
           const repoName: string = 'basicAndRunBuildActionRepo';
           const instance: IParserTestInstance = getCommandLineParserInstance(repoName, 'build');
@@ -124,7 +124,7 @@ describe(RushCommandLineParser.name, () => {
         });
       });
 
-      describe(`'rebuild' action`, () => {
+      describe("'rebuild' action", () => {
         it(`executes the package's 'build' script`, async () => {
           const repoName: string = 'basicAndRunRebuildActionRepo';
           const instance: IParserTestInstance = getCommandLineParserInstance(repoName, 'rebuild');
@@ -157,8 +157,8 @@ describe(RushCommandLineParser.name, () => {
       });
     });
 
-    describe(`in repo with 'rebuild' command overridden`, () => {
-      describe(`'build' action`, () => {
+    describe("in repo with 'rebuild' command overridden", () => {
+      describe("'build' action", () => {
         it(`executes the package's 'build' script`, async () => {
           const repoName: string = 'overrideRebuildAndRunBuildActionRepo';
           const instance: IParserTestInstance = getCommandLineParserInstance(repoName, 'build');
@@ -190,7 +190,7 @@ describe(RushCommandLineParser.name, () => {
         });
       });
 
-      describe(`'rebuild' action`, () => {
+      describe("'rebuild' action", () => {
         it(`executes the package's 'rebuild' script`, async () => {
           const repoName: string = 'overrideRebuildAndRunRebuildActionRepo';
           const instance: IParserTestInstance = getCommandLineParserInstance(repoName, 'rebuild');
@@ -223,8 +223,8 @@ describe(RushCommandLineParser.name, () => {
       });
     });
 
-    describe(`in repo with 'rebuild' or 'build' partially set`, () => {
-      describe(`'build' action`, () => {
+    describe("in repo with 'rebuild' or 'build' partially set", () => {
+      describe("'build' action", () => {
         it(`executes the package's 'build' script`, async () => {
           const repoName: string = 'overrideAndDefaultBuildActionRepo';
           const instance: IParserTestInstance = getCommandLineParserInstance(repoName, 'build');
@@ -255,7 +255,7 @@ describe(RushCommandLineParser.name, () => {
         });
       });
 
-      describe(`'rebuild' action`, () => {
+      describe("'rebuild' action", () => {
         it(`executes the package's 'build' script`, async () => {
           // broken
           const repoName: string = 'overrideAndDefaultRebuildActionRepo';
@@ -288,7 +288,7 @@ describe(RushCommandLineParser.name, () => {
       });
     });
 
-    describe(`in repo with 'build' command overridden as a global command`, () => {
+    describe("in repo with 'build' command overridden as a global command", () => {
       it(`throws an error when starting Rush`, async () => {
         const repoName: string = 'overrideBuildAsGlobalCommandRepo';
 
@@ -300,7 +300,7 @@ describe(RushCommandLineParser.name, () => {
       });
     });
 
-    describe(`in repo with 'rebuild' command overridden as a global command`, () => {
+    describe("in repo with 'rebuild' command overridden as a global command", () => {
       it(`throws an error when starting Rush`, async () => {
         const repoName: string = 'overrideRebuildAsGlobalCommandRepo';
 
@@ -312,7 +312,7 @@ describe(RushCommandLineParser.name, () => {
       });
     });
 
-    describe(`in repo with 'build' command overridden with 'safeForSimultaneousRushProcesses=true'`, () => {
+    describe("in repo with 'build' command overridden with 'safeForSimultaneousRushProcesses=true'", () => {
       it(`throws an error when starting Rush`, async () => {
         const repoName: string = 'overrideBuildWithSimultaneousProcessesRepo';
 
@@ -324,7 +324,7 @@ describe(RushCommandLineParser.name, () => {
       });
     });
 
-    describe(`in repo with 'rebuild' command overridden with 'safeForSimultaneousRushProcesses=true'`, () => {
+    describe("in repo with 'rebuild' command overridden with 'safeForSimultaneousRushProcesses=true'", () => {
       it(`throws an error when starting Rush`, async () => {
         const repoName: string = 'overrideRebuildWithSimultaneousProcessesRepo';
 

apps/rush/src/test/MinimalRushConfiguration.test.ts

@@ -5,7 +5,7 @@ import * as path from 'path';
 
 import { MinimalRushConfiguration } from '../MinimalRushConfiguration';
 
-describe('MinimalRushConfiguration', () => {
+describe(MinimalRushConfiguration.name, () => {
   afterEach(() => {
     jest.restoreAllMocks();
   });

build-tests/heft-jest-reporters-test/src/test/index.test.ts

@@ -3,7 +3,7 @@
 
 import { addThreeStars } from '..';
 
-describe('addThreeStars', () => {
+describe(addThreeStars.name, () => {
   it('adds three stars', () => {
     expect(addThreeStars('***Hello World')).toEqual('***Hello World***');
   });

eslint/eslint-plugin-packlets/src/test/Path.test.ts

@@ -15,7 +15,7 @@ function relativeCaseInsensitive(from: string, to: string) {
   return toPosixPath(Path['_relativeCaseInsensitive'](toNativePath(from), toNativePath(to)));
 }
 
-describe('Path', () => {
+describe(Path.name, () => {
   test('_detectCaseSensitive()', () => {
     // NOTE: To ensure these tests are deterministic, only use absolute paths
     expect(relativeCaseInsensitive('/', '/')).toEqual('');