Exempt tslib from indirect call transform (#47070)

Author: rbuckton

src/compiler/transformers/module/module.ts

@@ -1853,7 +1853,7 @@ namespace ts {
             if (isIdentifier(node.expression)) {
                 const expression = substituteExpressionIdentifier(node.expression);
                 noSubstitution[getNodeId(expression)] = true;
-                if (!isIdentifier(expression)) {
+                if (!isIdentifier(expression) && !(getEmitFlags(node.expression) & EmitFlags.HelperName)) {
                     return addEmitFlags(
                         factory.updateCallExpression(node,
                             expression,
@@ -1872,7 +1872,7 @@ namespace ts {
             if (isIdentifier(node.tag)) {
                 const tag = substituteExpressionIdentifier(node.tag);
                 noSubstitution[getNodeId(tag)] = true;
-                if (!isIdentifier(tag)) {
+                if (!isIdentifier(tag) && !(getEmitFlags(node.tag) & EmitFlags.HelperName)) {
                     return addEmitFlags(
                         factory.updateTaggedTemplateExpression(node,
                             tag,

tests/baselines/reference/es5-importHelpersAsyncFunctions.js

@@ -23,8 +23,8 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.foo = void 0;
 var tslib_1 = require("tslib");
 function foo() {
-    return (0, tslib_1.__awaiter)(this, void 0, void 0, function () {
-        return (0, tslib_1.__generator)(this, function (_a) {
+    return tslib_1.__awaiter(this, void 0, void 0, function () {
+        return tslib_1.__generator(this, function (_a) {
             return [2 /*return*/];
         });
     });

tests/baselines/reference/esModuleInteropImportTSLibHasImport.js

@@ -26,7 +26,7 @@ exports.username = username;
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 const tslib_1 = require("tslib");
-(0, tslib_1.__exportStar)(require("./username"), exports);
+tslib_1.__exportStar(require("./username"), exports);
 //// [hello.js]
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
@@ -36,6 +36,6 @@ exports.default = sayHello;
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 const tslib_1 = require("tslib");
-const hello_1 = (0, tslib_1.__importDefault)(require("./hello"));
+const hello_1 = tslib_1.__importDefault(require("./hello"));
 const utils_1 = require("./utils");
 (0, hello_1.default)((0, utils_1.username)());

tests/baselines/reference/esModuleInteropTslibHelpers.js

@@ -24,7 +24,7 @@ export { Bar }
 exports.__esModule = true;
 exports.Foo = void 0;
 var tslib_1 = require("tslib");
-var path_1 = (0, tslib_1.__importDefault)(require("path"));
+var path_1 = tslib_1.__importDefault(require("path"));
 path_1["default"].resolve("", "../");
 var Foo = /** @class */ (function () {
     function Foo() {
@@ -37,7 +37,7 @@ exports.Foo = Foo;
 exports.__esModule = true;
 exports.Foo2 = void 0;
 var tslib_1 = require("tslib");
-var path = (0, tslib_1.__importStar)(require("path"));
+var path = tslib_1.__importStar(require("path"));
 path.resolve("", "../");
 var Foo2 = /** @class */ (function () {
     function Foo2() {
@@ -50,7 +50,7 @@ exports.Foo2 = Foo2;
 exports.__esModule = true;
 exports.Foo3 = void 0;
 var tslib_1 = require("tslib");
-var path_1 = (0, tslib_1.__importDefault)(require("path"));
+var path_1 = tslib_1.__importDefault(require("path"));
 (0, path_1["default"])("", "../");
 var Foo3 = /** @class */ (function () {
     function Foo3() {
@@ -63,6 +63,6 @@ exports.Foo3 = Foo3;
 exports.__esModule = true;
 exports.Bar = void 0;
 var tslib_1 = require("tslib");
-var path_1 = (0, tslib_1.__importStar)(require("path"));
+var path_1 = tslib_1.__importStar(require("path"));
 exports.Bar = path_1.Bar;
 (0, path_1["default"])("", "../");

tests/baselines/reference/exportAsNamespace_missingEmitHelpers.js

@@ -15,4 +15,4 @@ exports.__esModule = true;
 exports.__esModule = true;
 exports.ns = void 0;
 var tslib_1 = require("tslib");
-exports.ns = (0, tslib_1.__importStar)(require("./a")); // Error
+exports.ns = tslib_1.__importStar(require("./a")); // Error

tests/baselines/reference/importHelpers.js

@@ -58,7 +58,7 @@ var A = /** @class */ (function () {
 }());
 exports.A = A;
 var B = /** @class */ (function (_super) {
-    (0, tslib_1.__extends)(B, _super);
+    tslib_1.__extends(B, _super);
     function B() {
         return _super !== null && _super.apply(this, arguments) || this;
     }
@@ -70,21 +70,21 @@ var C = /** @class */ (function () {
     }
     C.prototype.method = function (x) {
     };
-    (0, tslib_1.__decorate)([
-        (0, tslib_1.__param)(0, dec),
-        (0, tslib_1.__metadata)("design:type", Function),
-        (0, tslib_1.__metadata)("design:paramtypes", [Number]),
-        (0, tslib_1.__metadata)("design:returntype", void 0)
+    tslib_1.__decorate([
+        tslib_1.__param(0, dec),
+        tslib_1.__metadata("design:type", Function),
+        tslib_1.__metadata("design:paramtypes", [Number]),
+        tslib_1.__metadata("design:returntype", void 0)
     ], C.prototype, "method", null);
-    C = (0, tslib_1.__decorate)([
+    C = tslib_1.__decorate([
         dec
     ], C);
     return C;
 }());
 function id(x) {
     return x;
 }
-exports.result = id(templateObject_1 || (templateObject_1 = (0, tslib_1.__makeTemplateObject)(["hello world"], ["hello world"])));
+exports.result = id(templateObject_1 || (templateObject_1 = tslib_1.__makeTemplateObject(["hello world"], ["hello world"])));
 var templateObject_1;
 //// [script.js]
 var __extends = (this && this.__extends) || (function () {

tests/baselines/reference/importHelpersAmd.js

@@ -36,9 +36,9 @@ define(["require", "exports", "tslib", "./a", "./a"], function (require, exports
     "use strict";
     Object.defineProperty(exports, "__esModule", { value: true });
     exports.B = void 0;
-    (0, tslib_1.__exportStar)(a_2, exports);
+    tslib_1.__exportStar(a_2, exports);
     var B = /** @class */ (function (_super) {
-        (0, tslib_1.__extends)(B, _super);
+        tslib_1.__extends(B, _super);
         function B() {
             return _super !== null && _super.apply(this, arguments) || this;
         }

tests/baselines/reference/importHelpersInIsolatedModules.js

@@ -45,7 +45,7 @@ var A = /** @class */ (function () {
 }());
 exports.A = A;
 var B = /** @class */ (function (_super) {
-    (0, tslib_1.__extends)(B, _super);
+    tslib_1.__extends(B, _super);
     function B() {
         return _super !== null && _super.apply(this, arguments) || this;
     }
@@ -57,13 +57,13 @@ var C = /** @class */ (function () {
     }
     C.prototype.method = function (x) {
     };
-    (0, tslib_1.__decorate)([
-        (0, tslib_1.__param)(0, dec),
-        (0, tslib_1.__metadata)("design:type", Function),
-        (0, tslib_1.__metadata)("design:paramtypes", [Number]),
-        (0, tslib_1.__metadata)("design:returntype", void 0)
+    tslib_1.__decorate([
+        tslib_1.__param(0, dec),
+        tslib_1.__metadata("design:type", Function),
+        tslib_1.__metadata("design:paramtypes", [Number]),
+        tslib_1.__metadata("design:returntype", void 0)
     ], C.prototype, "method", null);
-    C = (0, tslib_1.__decorate)([
+    C = tslib_1.__decorate([
         dec
     ], C);
     return C;
@@ -76,7 +76,7 @@ var A = /** @class */ (function () {
     return A;
 }());
 var B = /** @class */ (function (_super) {
-    (0, tslib_1.__extends)(B, _super);
+    tslib_1.__extends(B, _super);
     function B() {
         return _super !== null && _super.apply(this, arguments) || this;
     }
@@ -87,13 +87,13 @@ var C = /** @class */ (function () {
     }
     C.prototype.method = function (x) {
     };
-    (0, tslib_1.__decorate)([
-        (0, tslib_1.__param)(0, dec),
-        (0, tslib_1.__metadata)("design:type", Function),
-        (0, tslib_1.__metadata)("design:paramtypes", [Number]),
-        (0, tslib_1.__metadata)("design:returntype", void 0)
+    tslib_1.__decorate([
+        tslib_1.__param(0, dec),
+        tslib_1.__metadata("design:type", Function),
+        tslib_1.__metadata("design:paramtypes", [Number]),
+        tslib_1.__metadata("design:returntype", void 0)
     ], C.prototype, "method", null);
-    C = (0, tslib_1.__decorate)([
+    C = tslib_1.__decorate([
         dec
     ], C);
     return C;

tests/baselines/reference/importHelpersInTsx.js

@@ -24,7 +24,7 @@ export declare function __awaiter(thisArg: any, _arguments: any, P: Function, ge
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.x = void 0;
 var tslib_1 = require("tslib");
-exports.x = React.createElement("span", (0, tslib_1.__assign)({}, o));
+exports.x = React.createElement("span", tslib_1.__assign({}, o));
 //// [script.js]
 var __assign = (this && this.__assign) || function () {
     __assign = Object.assign || function(t) {

tests/baselines/reference/importHelpersNoHelpers.js

@@ -46,15 +46,15 @@ exports.x = 1;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.B = exports.A = void 0;
 var tslib_1 = require("tslib");
-(0, tslib_1.__exportStar)(require("./other"), exports);
+tslib_1.__exportStar(require("./other"), exports);
 var A = /** @class */ (function () {
     function A() {
     }
     return A;
 }());
 exports.A = A;
 var B = /** @class */ (function (_super) {
-    (0, tslib_1.__extends)(B, _super);
+    tslib_1.__extends(B, _super);
     function B() {
         return _super !== null && _super.apply(this, arguments) || this;
     }
@@ -66,20 +66,20 @@ var C = /** @class */ (function () {
     }
     C.prototype.method = function (x) {
     };
-    (0, tslib_1.__decorate)([
-        (0, tslib_1.__param)(0, dec),
-        (0, tslib_1.__metadata)("design:type", Function),
-        (0, tslib_1.__metadata)("design:paramtypes", [Number]),
-        (0, tslib_1.__metadata)("design:returntype", void 0)
+    tslib_1.__decorate([
+        tslib_1.__param(0, dec),
+        tslib_1.__metadata("design:type", Function),
+        tslib_1.__metadata("design:paramtypes", [Number]),
+        tslib_1.__metadata("design:returntype", void 0)
     ], C.prototype, "method", null);
-    C = (0, tslib_1.__decorate)([
+    C = tslib_1.__decorate([
         dec
     ], C);
     return C;
 }());
 var o = { a: 1 };
-var y = (0, tslib_1.__assign)({}, o);
-var x = (0, tslib_1.__rest)(y, []);
+var y = tslib_1.__assign({}, o);
+var x = tslib_1.__rest(y, []);
 //// [script.js]
 var __extends = (this && this.__extends) || (function () {
     var extendStatics = function (d, b) {