Unhandled Exception: System.ObjectDisposedException: Cannot access a closed file.

[chucklu]

Hi,
When I try to git push ,I got this exception.

$ git push
fatal: TaskCanceledException encountered.
   A task was canceled.

Unhandled Exception: System.ObjectDisposedException: Cannot access a closed file.
   at System.IO.__Error.FileNotOpen()
   at System.IO.FileStream.Flush(Boolean flushToDisk)
   at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
   at Microsoft.Alm.Git.Trace.Microsoft.Alm.Git.ITrace.Flush()
   at Microsoft.Alm.Cli.ConsoleFunctions.Exit(Program program, Int32 exitcode, String message, String path, Int32 line, String name)
   at Microsoft.Alm.Cli.Program.Exit(Int32 exitcode, String message, String path, Int32 line, String name)
   at Microsoft.Alm.Cli.CommonFunctions.DieMessage(Program program, String message, String path, Int32 line, String name)
   at Microsoft.Alm.Cli.Program.Die(String message, String path, Int32 line, String name)
   at Microsoft.Alm.Cli.CommonFunctions.DieException(Program program, Exception exception, String path, Int32 line, String name)
   at Microsoft.Alm.Cli.Program.Die(Exception exception, String path, Int32 line, String name)
   at Microsoft.Alm.Cli.Program.Run(String[] args)
   at Microsoft.Alm.Cli.Program.Main(String[] args)
fatal: TaskCanceledException encountered.
   A task was canceled.

Unhandled Exception: System.ObjectDisposedException: Cannot access a closed file.
   at System.IO.__Error.FileNotOpen()
   at System.IO.FileStream.Flush(Boolean flushToDisk)
   at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
   at Microsoft.Alm.Git.Trace.Microsoft.Alm.Git.ITrace.Flush()
   at Microsoft.Alm.Cli.ConsoleFunctions.Exit(Program program, Int32 exitcode, String message, String path, Int32 line, String name)
   at Microsoft.Alm.Cli.Program.Exit(Int32 exitcode, String message, String path, Int32 line, String name)
   at Microsoft.Alm.Cli.CommonFunctions.DieMessage(Program program, String message, String path, Int32 line, String name)
   at Microsoft.Alm.Cli.Program.Die(String message, String path, Int32 line, String name)
   at Microsoft.Alm.Cli.CommonFunctions.DieException(Program program, Exception exception, String path, Int32 line, String name)
   at Microsoft.Alm.Cli.Program.Die(Exception exception, String path, Int32 line, String name)
   at Microsoft.Alm.Cli.Program.Run(String[] args)
   at Microsoft.Alm.Cli.Program.Main(String[] args)

[whoisj]

@chucklu the stack trace you've shared points to the standard pipe being closed prior to the GCM exiting, which caused the GCM to hit an access violation.

Could you setup some log gathering to provide additional data/information? If so:

1. Open Command Prompt
2. Run SET GIT_TRACE 1
3. Run SET GCM_TRACE 1
4. cd into the root of the repository where the error occurs.
5. Run git push
6. Copy the output and paste into this thread as a response - please remove any private and/or secret data contained in the output.

[chucklu]

@whoisj hi,what did you mean by “Command Prompt”?
I try to run the command in cmd.exe of windows,I got this "Environment variable git_trace 1 not defined".
I try to run the command in git bash,then git push again.
I just got the same exception as I submit above.

Another detail is ,I have run the command "git config credential.writelog true ".
But when I open the .git\credential.log,there is nothing in it,just an empty file.

[chucklu]

Hi,
I find how to run the command you mentioned above How can I debug git/git-shell related problems?
Then I got the detail:
10:35:36.004889 ...tionArguments.cs:528 trace: [SetProxy] failed to parse 'domain:port'.
10:35:36.004889 ...tionArguments.cs:531 trace: [SetProxy] proxy cleared.
10:35:36.005892 ...\Common.cs:243 trace: [EnableTraceLogging] trace logging enabled.
10:35:36.027952 ...\Common.cs:74 trace: [CreateAuthentication] detecting authority type for 'https://github.com/'.
10:35:36.037978 ...uthentication.cs:134 trace: [GetAuthentication] created GitHub authentication for 'https://github.com/'.
10:35:36.037978 ...\Common.cs:139 trace: [CreateAuthentication] authority for 'https://github.com/' is GitHub.
10:35:36.048005 ...seSecureStore.cs:134 trace: [ReadCredentials] credentials for 'git:https://github.com' read from store.
10:35:36.049008 ...uthentication.cs:163 trace: [GetCredentials] credentials for 'https://github.com/' found.
10:35:51.075325 ...\Program.cs:422 trace: [Run] System.Threading.Tasks.TaskCanceledException: A task was canceled.
10:35:51.076326 ...\Common.cs:492 trace: [LogEvent] System.Threading.Tasks.TaskCanceledException: A task was canceled.

[whoisj]

Thanks for that!

10:35:36.004889 ...tionArguments.cs:528 trace: [SetProxy] failed to parse 'domain:port'.

Given the above error, what does your remote URL look like?

[chucklu]

13:18:44.118297 ...\Common.cs:461 trace: [LoadOperationArguments] http.pro xy = 'shanghai01prx11_p.net.github.net:8080'.

@whoisj something like this

[chucklu]

@whoisj hi, I have test the SetProxy method in class Impl in file git-credential-manager-for-windows\cli-shared\operationarguments.cs
It seems that I need add http:// for the proxy, otherwise Uri.TryCreate(url, UriKind.Absolute, out tmp) will return false.

[chucklu]

I add the http:// for the http.proxy,then the gcm works.

hi,I think you can add the http:// for the url without it automatically.

[whoisj]

I think you can add the http:// for the url without it automatically.

I could, but it's the .NET Framework complaining about the URL format. To detect and correct, I'd have to design, author, develop, and maintain URL parsing code for the GCM. That seems fraught with error - additionally, proxies can use any protocol so assuming "http://" could be even worse as the network attempt would just fail without much feedback as to why.

I am very happy that you figured out the issues. Enjoy!

[chucklu]

@whoisj hi ,I understand your concern. But the git for windows can recognize the proxy url without http:// .

[whoisj]

@whoisj hi ,I understand your concern. But the git for windows can recognize the proxy url without http:// .

Fair enough then, I'll take a note and see what can be done. Thanks again. 😄

[ericblade]

Am experiencing this this evening. No proxies involved.

fatal: HttpRequestException encountered.
   An error occurred while sending the request.

Unhandled Exception: System.ObjectDisposedException: Cannot access a closed file.
   at System.IO.__Error.FileNotOpen()
   at System.IO.FileStream.Flush(Boolean flushToDisk)
   at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
   at Microsoft.Alm.Git.Trace.Microsoft.Alm.Git.ITrace.Flush()
   at Microsoft.Alm.Cli.Program.Die(String message)
   at Microsoft.Alm.Cli.Program.Die(Exception exception)
   at Microsoft.Alm.Cli.Program.Main(String[] args)

with tracing:

D:\src\mws-advanced>git push origin master
01:13:32.033344 git.c:371               trace: built-in: git 'push' 'origin' 'master'
01:13:32.073357 run-command.c:369       trace: run_command: 'git-remote-https' 'origin' 'https://github.com/ericblade/mws-advanced.git'
01:13:36.510318 run-command.c:369       trace: run_command: 'git credential-manager get'
01:13:36.580816 git.c:596               trace: exec: 'git-credential-manager' 'get'
01:13:36.580816 run-command.c:369       trace: run_command: 'git-credential-manager' 'get'
01:13:36.650816 ...\Program.cs:671      trace: [Main] git-credential-manager (v1.9.0) 'get'
01:13:36.680825 ...Configuration.cs:243 trace: [LoadGitConfiguration] git Portable, UserOnly config read, 35 entries.
01:13:36.698823 ...\Where.cs:231        trace: [FindGitInstallations] found 1 Git installation(s).
01:13:36.700824 ...Configuration.cs:243 trace: [LoadGitConfiguration] git All config read, 49 entries.
01:13:36.702823 ...\Program.cs:686      trace: [EnableTraceLogging] trace logging enabled.
01:13:36.702823 ...\Program.cs:691      trace: [EnableTraceLogging] git local config found at 'D:\src\mws-advanced\.git\config'.
01:13:36.704823 ...\Program.cs:737      trace: [EnableTraceLogging] trace log destination is 'D:\src\mws-advanced\.git'.
01:13:36.714825 ...\Program.cs:384      trace: [CreateAuthentication] detecting authority type for 'https://github.com/'.
01:13:36.720826 ...uthentication.cs:126 trace: [GetAuthentication] created GitHub authentication for 'https://github.com/'.
01:13:36.720826 ...\Program.cs:442      trace: [CreateAuthentication] authority for 'https://github.com/' is GitHub.
01:13:36.726822 ...seSecureStore.cs:134 trace: [ReadCredentials] credentials for 'git:https://github.com' read from store.
01:13:36.726822 ...uthentication.cs:153 trace: [GetCredentials] credentials for 'https://github.com/' found.
01:13:36.834312 ...\Program.cs:152      trace: [Die] System.Net.Http.HttpRequestException: An error occurred while sending the request. ---> System.Net.WebException: The request was aborted: Could not create SSL/TLS secure channel.
   at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult)
   at System.Net.Http.HttpClientHandler.GetResponseCallback(IAsyncResult ar)
   --- End of inner exception stack trace ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitHub.Authentication.Authority.<ValidateCredentials>d__6.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitHub.Authentication.Authentication.<ValidateCredentials>d__29.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Cli.Program.<>c__DisplayClass99_4.<<QueryCredentials>b__4>d.MoveNext()
01:13:36.835305 ...\Program.cs:193      trace: [LogEvent] System.Net.Http.HttpRequestException: An error occurred while sending the request. ---> System.Net.WebException: The request was aborted: Could not create SSL/TLS secure channel.
   at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult)
   at System.Net.Http.HttpClientHandler.GetResponseCallback(IAsyncResult ar)
   --- End of inner exception stack trace ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitHub.Authentication.Authority.<ValidateCredentials>d__6.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitHub.Authentication.Authentication.<ValidateCredentials>d__29.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Cli.Program.<>c__DisplayClass99_4.<<QueryCredentials>b__4>d.MoveNext()
01:13:36.836299 ...\Program.cs:170      trace: [Die] fatal: HttpRequestException encountered.
   An error occurred while sending the request.
fatal: HttpRequestException encountered.
   An error occurred while sending the request.

Unhandled Exception: System.ObjectDisposedException: Cannot access a closed file.
   at System.IO.__Error.FileNotOpen()
   at System.IO.FileStream.Flush(Boolean flushToDisk)
   at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
   at Microsoft.Alm.Git.Trace.Microsoft.Alm.Git.ITrace.Flush()
   at Microsoft.Alm.Cli.Program.Die(String message)
   at Microsoft.Alm.Cli.Program.Die(Exception exception)
   at Microsoft.Alm.Cli.Program.Main(String[] args)
01:13:36.846432 run-command.c:369       trace: run_command: 'bash' '-c' 'cat >/dev/tty && read -r line </dev/tty && echo "$line"'
Username for 'https://github.com': ^C

WSL git is also not working, but setting GIT_TRACE there does nothing.

[chucklu]

Hi @ericblade , I find the error message in your output. "Could not create SSL/TLS secure channel"
And I found someone else already submit another issue #555 .
There is a solution in that issue:
Updating git to 2.16.2.windows.1 solved the issue.