github: conditionally append OTP header

Only append the "X-GitHub-OTP" header if there's a value to append with it. Including the header without a value appears cause github.com to emit 2FA SMS messages.

Author: whoisj

GitHub.Authentication/Src/Authority.cs

@@ -86,7 +86,11 @@ public async Task<AuthenticationResult> AcquireToken(
             };
 
             options.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue(GitHubApiAcceptsHeaderValue));
-            options.Headers.Add(GitHubOptHeader, authenticationCode);
+
+            if (!string.IsNullOrWhiteSpace(authenticationCode))
+            {
+                options.Headers.Add(GitHubOptHeader, authenticationCode);
+            }
 
             // Create the authority Uri.
             var requestUri = targetUri.CreateWith(_authorityUrl);