vsts: correct HTTP status condition.

whoisj · whoisj · commit f0d43b36b385 · 2018-07-20T10:28:21.000-04:00
Fixes an obvisouly wrong condition.
diff --git a/VisualStudioTeamServices.Authentication/Src/Authority.cs b/VisualStudioTeamServices.Authentication/Src/Authority.cs
@@ -371,7 +371,7 @@ public async Task<bool> ValidateToken(TargetUri targetUri, Token token)
                     {
                         // Even if the service responded, if the issue isn't a 400 class response then
                         // the credentials were likely not rejected.
-                        if ((int)response.StatusCode < 400 && (int)response.StatusCode >= 500)
+                        if ((int)response.StatusCode < 400 || (int)response.StatusCode >= 500)
                         {
                             Trace.WriteLine($"unable to validate credentials for '{targetUri}', unexpected response [{(int)response.StatusCode} {response.ReasonPhrase}].");
 

Original file line number	Diff line number	Diff line change
`@@ -371,7 +371,7 @@ public async Task<bool> ValidateToken(TargetUri targetUri, Token token)`
`371`	`371`	`{`
`372`	`372`	`// Even if the service responded, if the issue isn't a 400 class response then`
`373`	`373`	`// the credentials were likely not rejected.`
`374`		`- if ((int)response.StatusCode < 400 && (int)response.StatusCode >= 500)`
	`374`	`+ if ((int)response.StatusCode < 400 \|\| (int)response.StatusCode >= 500)`
`375`	`375`	`{`
`376`	`376`	`Trace.WriteLine($"unable to validate credentials for '{targetUri}', unexpected response [{(int)response.StatusCode} {response.ReasonPhrase}].");`
`377`	`377`