build: cleanup warnings

Disable CA2205 warning about duplicating NetFx methods via P/Invoke.

Author: whoisj

VisualStudioTeamServices.Authentication/Test/AuthorityFake.cs

@@ -62,6 +62,18 @@ public async Task<Token> GeneratePersonalAccessToken(TargetUri targetUri, Token
             return await Task.FromResult(new Token("personal-access-token", TokenType.Personal));
         }
 
+        /// <summary>
+        /// Generates a personal access token for use with Visual Studio Team Services.
+        /// <para/>
+        /// Returns the acquired token if successful; otherwise <see langword="null"/>;
+        /// </summary>
+        /// <param name="targetUri">The uniform resource indicator of the resource access tokens are being requested for.</param>
+        /// <param name="accessToken">Access token granted by the identity authority (Azure).</param>
+        /// <param name="tokenScope">The requested access scopes to be granted to the token.</param>
+        /// <param name="requireCompactToken">`<see langword="true"/>` if requesting a compact format token; otherwise `<see langword="false"/>`.</param>
+        public Task<Token> GeneratePersonalAccessToken(TargetUri targetUri, Token accessToken, TokenScope tokenScope, bool requireCompactToken)
+            => GeneratePersonalAccessToken(targetUri, accessToken, tokenScope, requireCompactToken, null);
+
         /// <summary>
         /// Acquires a <see cref="Token"/> from the authority via an interactive user logon prompt.
         /// <para/>
@@ -72,7 +84,7 @@ public async Task<Token> GeneratePersonalAccessToken(TargetUri targetUri, Token
         /// <param name="resource">Identifier of the target resource that is the recipient of the requested token.</param>
         /// <param name="redirectUri">Address to return to upon receiving a response from the authority.</param>
         /// <param name="queryParameters">optional value, appended as-is to the query string in the HTTP authentication request to the authority.</param>
-        public async Task<Token> InteractiveAcquireToken(TargetUri targetUri, string clientId, string resource, Uri redirectUri, string queryParameters = null)
+        public async Task<Token> InteractiveAcquireToken(TargetUri targetUri, string clientId, string resource, Uri redirectUri, string queryParameters)
         {
             Assert.Equal(ExpectedQueryParameters, queryParameters);
 

analysisRules.ruleset

@@ -32,6 +32,7 @@
     <Rule Id="CA2201" Action="None" />
     <Rule Id="CA2202" Action="None" />
     <Rule Id="CA2204" Action="None" />
+    <Rule Id="CA2205" Action="None" />
     <Rule Id="CA2208" Action="None" />
     <Rule Id="CA2210" Action="None" />
     <Rule Id="CA2225" Action="None" />