Skip to content

Commit 936d6a5

Browse files
Breaking: Rename Project -> MakeCodeProject (#2)
* Breaking: Rename Project -> MakeCodeProject * Remove unused import that wasn't renamed
1 parent d608899 commit 936d6a5

15 files changed

+39
-40
lines changed

docs/vanilla.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ Use {@link vanilla.MakeCodeFrameDriver | MakeCodeFrameDriver} class to create a
3232

3333
```js
3434
import {
35-
Project,
3635
MakeCodeFrameDriver,
3736
createMakeCodeURL,
3837
} from "@microbit/makecode-embed/vanilla";

src/react/MakeCodeBlocksRendering.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@
44
*/
55
import React, { useState, useEffect, ReactNode } from 'react';
66
import { useMakeCodeRenderBlocksContext } from './MakeCodeRenderBlocksProvider.js';
7-
import { BlockLayout, Project } from '../vanilla/pxt.js';
7+
import { BlockLayout, MakeCodeProject } from '../vanilla/pxt.js';
88

99
export interface MakeCodeBlocksRenderingProps {
1010
className?: string;
11-
code?: string | Project;
11+
code?: string | MakeCodeProject;
1212
packageId?: string;
1313
package?: string;
1414
snippetMode?: boolean;

src/react/MakeCodeFrame.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import {
1616
EditorMessageTutorialEventRequest,
1717
EditorWorkspaceSaveRequest,
1818
EditorWorkspaceSyncRequest,
19-
Project,
19+
MakeCodeProject,
2020
ProjectFilters,
2121
} from '../vanilla/pxt.js';
2222

@@ -38,7 +38,7 @@ export interface MakeCodeFrameProps
3838
// https://github.com/microsoft/pxt-microbit/blob/master/pxtarget.json#L605C6-L605C14
3939
queryParams?: Record<string, string>;
4040

41-
initialProjects: () => Promise<Project[]>;
41+
initialProjects: () => Promise<MakeCodeProject[]>;
4242

4343
controllerId?: string;
4444
filters?: ProjectFilters;

src/react/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export type {
4242
ImportProjectOptions,
4343
InfoMessage,
4444
LanguageRestriction,
45-
Project,
45+
MakeCodeProject,
4646
ProjectCreationOptions,
4747
ProjectFilters,
4848
RenderBlocksOptions,

src/stories/MakeCodeToolbar.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { MutableRefObject, RefObject } from 'react';
22
import { MakeCodeFrameDriver } from '../vanilla/makecode-frame-driver.js';
33
import { defaultMakeCodeProject } from '../vanilla/examples.js';
4-
import { Project } from '../vanilla/pxt.js';
4+
import { MakeCodeProject } from '../vanilla/pxt.js';
55

66
const toolbarRowStyle = {
77
fontFamily: 'sans-serif',
@@ -16,7 +16,7 @@ const MakeCodeToolbar = ({
1616
savedProjects,
1717
}: {
1818
driver: RefObject<MakeCodeFrameDriver>;
19-
savedProjects: MutableRefObject<Map<string, Project>>;
19+
savedProjects: MutableRefObject<Map<string, MakeCodeProject>>;
2020
}) => {
2121
return (
2222
<div style={{ display: 'flex', flexDirection: 'column' }}>

src/stories/fixtures.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Project } from '../vanilla/pxt.js';
1+
import { MakeCodeProject } from '../vanilla/pxt.js';
22

33
export const project = {
44
text: {
@@ -9,7 +9,7 @@ export const project = {
99
'pxt.json':
1010
'{\n "name": "Untitled",\n "dependencies": {\n "core": "*"\n , "radio": "*"\n },\n "description": "",\n "files": [\n "main.blocks",\n "main.ts",\n "README.md"\n ]\n}',
1111
},
12-
} as Project;
12+
} as MakeCodeProject;
1313

1414
export const projectWithLayout = {
1515
text: {
@@ -63,9 +63,9 @@ export const projectWithLayout = {
6363
</block>
6464
</xml>`,
6565
},
66-
} as Project;
66+
} as MakeCodeProject;
6767

68-
export const projectWithExtensionBlock: Project = {
68+
export const projectWithExtensionBlock: MakeCodeProject = {
6969
text: {
7070
'README.md': '',
7171
'main.blocks':
@@ -136,7 +136,7 @@ export const initialProject = {
136136
},
137137
};
138138

139-
export const projectWithCustomBlock: Project = {
139+
export const projectWithCustomBlock: MakeCodeProject = {
140140
text: {
141141
'README.md': '',
142142
'custom.ts':
@@ -149,7 +149,7 @@ export const projectWithCustomBlock: Project = {
149149
},
150150
};
151151

152-
export const projectWithUserLayout: Project = {
152+
export const projectWithUserLayout: MakeCodeProject = {
153153
text: {
154154
'README.md': '',
155155
'main.blocks':

src/stories/react/MakeCodeBlocksRendering.stories.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Meta, StoryObj } from '@storybook/react';
22
import { ReactNode, useState } from 'react';
33
import MakeCodeBlocksRendering from '../../react/MakeCodeBlocksRendering.js';
44
import { MakeCodeRenderBlocksProvider } from '../../react/MakeCodeRenderBlocksProvider.js';
5-
import { BlockLayout, Project } from '../../vanilla/pxt.js';
5+
import { BlockLayout, MakeCodeProject } from '../../vanilla/pxt.js';
66
import {
77
initialProject,
88
project,
@@ -190,7 +190,7 @@ export const Robust: Story = {
190190
return (
191191
<StoryWrapper key={version}>
192192
<MakeCodeRenderBlocksProvider version={adaptStorybookVersion(version)}>
193-
<MakeCodeBlocksRendering code={{} as Project} />
193+
<MakeCodeBlocksRendering code={{} as MakeCodeProject} />
194194
</MakeCodeRenderBlocksProvider>
195195
</StoryWrapper>
196196
);
@@ -229,7 +229,7 @@ export const EmptyToBlocksTransition: Story = {
229229
name: 'Empty to blocks transition',
230230
render: (args) => {
231231
const { version } = args;
232-
const [project, setProject] = useState<Project>(initialProject);
232+
const [project, setProject] = useState<MakeCodeProject>(initialProject);
233233
return (
234234
<StoryWrapper key={version}>
235235
<div style={{ display: 'grid', gridTemplateColumns: '50% 50%' }}>

src/stories/react/MakeCodeFrame.stories.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
default as MakeCodeFrame,
77
MakeCodeFrameProps,
88
} from '../../react/MakeCodeFrame.js';
9-
import { Project } from '../../vanilla/pxt.js';
9+
import { MakeCodeProject } from '../../vanilla/pxt.js';
1010
import { controllerId } from '../config.js';
1111
import StoryWrapper from '../StoryWrapper.js';
1212
import MakeCodeToolbar from '../MakeCodeToolbar.js';
@@ -30,7 +30,7 @@ type Story = StoryObj<typeof MakeCodeFrame>;
3030
const MakeCodeEditorWithControls = (
3131
props: Omit<MakeCodeFrameProps, 'initialProjects'>
3232
) => {
33-
const savedProjects = useRef<Map<string, Project>>(new Map());
33+
const savedProjects = useRef<Map<string, MakeCodeProject>>(new Map());
3434
const ref = useRef<MakeCodeFrameDriver>(null);
3535
const initialProjects = useCallback(async () => {
3636
if (savedProjects.current.size === 0) {

src/stories/vanilla/makecode-frame-driver.stories.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
MakeCodeFrameDriver,
77
Options,
88
} from '../../vanilla/makecode-frame-driver.js';
9-
import { Project } from '../../vanilla/pxt.js';
9+
import { MakeCodeProject } from '../../vanilla/pxt.js';
1010
import MakeCodeToolbar from '../MakeCodeToolbar.js';
1111
import StoryWrapper from '../StoryWrapper.js';
1212

@@ -17,7 +17,7 @@ interface StoryArgs {
1717
controller?: 1 | 2;
1818
queryParams?: Record<string, string>;
1919
};
20-
project?: Project;
20+
project?: MakeCodeProject;
2121
callbacks?: Partial<Options>;
2222
}
2323

@@ -30,7 +30,7 @@ export default meta;
3030
type Story = StoryObj<StoryArgs>;
3131

3232
const renderEditor = (args: StoryArgs) => {
33-
const savedProjects = useRef<Map<string, Project>>(new Map());
33+
const savedProjects = useRef<Map<string, MakeCodeProject>>(new Map());
3434
const ref = useRef<MakeCodeFrameDriver | null>(null);
3535
const cbRef = (div: HTMLElement | null) => {
3636
if (!div) {
@@ -50,7 +50,7 @@ const renderEditor = (args: StoryArgs) => {
5050
iframe.height = '100%';
5151
div.appendChild(iframe);
5252

53-
const savedProjects: Map<string, Project> = new Map();
53+
const savedProjects: Map<string, MakeCodeProject> = new Map();
5454

5555
// Create and initialise an instance of MakeCodeFrameDriver.
5656
ref.current = new MakeCodeFrameDriver(

src/stories/vanilla/makecode-render-blocks.stories.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@ import {
1313
projectWithMelody,
1414
projectWithTwoExtensions,
1515
} from '../fixtures.js';
16-
import { Project } from '../../vanilla/pxt.js';
16+
import { MakeCodeProject } from '../../vanilla/pxt.js';
1717
import StoryWrapper from '../StoryWrapper.js';
1818

1919
interface StoryArgs {
2020
options: MakeCodeRenderBlocksOptions | undefined;
21-
project: Project;
21+
project: MakeCodeProject;
2222
}
2323

2424
const meta: Meta<StoryArgs> = {

src/vanilla/examples.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { Project } from './pxt.js';
1+
import { MakeCodeProject } from './pxt.js';
22

3-
export const defaultMakeCodeProject: Project = {
3+
export const defaultMakeCodeProject: MakeCodeProject = {
44
text: {
55
'main.blocks':
66
'<xml xmlns="http://www.w3.org/1999/xhtml">\n <block type="pxt-on-start" id=",{,HjW]u:lVGcDRS_Cu|" x="-247" y="113"></block>\n</xml>',
@@ -11,7 +11,7 @@ export const defaultMakeCodeProject: Project = {
1111
},
1212
};
1313

14-
export const emptyMakeCodeProject: Project = {
14+
export const emptyMakeCodeProject: MakeCodeProject = {
1515
text: {
1616
'main.blocks':
1717
'<xml xmlns="http://www.w3.org/1999/xhtml">\n <variables></variables>\n</xml>',

src/vanilla/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export type {
3838
LanguageRestriction,
3939
PackageConfig,
4040
PackageExtension,
41-
Project,
41+
MakeCodeProject,
4242
ProjectCreationOptions,
4343
ProjectFilters,
4444
ProjectTemplate,

src/vanilla/makecode-frame-driver.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import {
2929
ImportProjectOptions,
3030
InfoMessage,
3131
LanguageRestriction,
32-
Project,
32+
MakeCodeProject,
3333
ProjectCreationOptions,
3434
ProjectFilters,
3535
RenderBlocksOptions,
@@ -64,7 +64,7 @@ export interface Options {
6464
* The projects will receive updates via `onWorkspaceSave` and should be stored keyed by header
6565
* id.
6666
*/
67-
initialProjects: () => Promise<Project[]>;
67+
initialProjects: () => Promise<MakeCodeProject[]>;
6868

6969
/**
7070
* Set this to a value representing your app.

src/vanilla/makecode-render-blocks.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* MakeCode handling that does not depend on React.
33
*/
44

5-
import { BlockLayout, Project } from './pxt.js';
5+
import { BlockLayout, MakeCodeProject } from './pxt.js';
66

77
const disposedMessage = 'Disposed';
88
const makecodeFailedToLoadMessage = 'Failed to load MakeCode to render blocks.';
@@ -22,7 +22,7 @@ export interface MakeCodeRenderBlocksReturn {
2222
}
2323

2424
export interface RenderBlocksRequest {
25-
code: string | Project;
25+
code: string | MakeCodeProject;
2626
options?: {
2727
packageId?: string;
2828
package?: string;
@@ -68,7 +68,7 @@ interface RenderBlocksResponseMessage {
6868
type RequestInputType = 'text' | 'blocks';
6969

7070
interface RenderBlocksRequestResponse {
71-
input: Project | string;
71+
input: MakeCodeProject | string;
7272
sent: boolean;
7373
type: RequestInputType;
7474
req: RenderBlocksRequestMessage;
@@ -129,7 +129,7 @@ export const createMakeCodeRenderBlocks = (
129129
};
130130

131131
const findBestCode = (
132-
code: string | Project,
132+
code: string | MakeCodeProject,
133133
ignoreBlocks?: boolean
134134
): { type: RequestInputType; code: string } => {
135135
if (typeof code === 'string') {

src/vanilla/pxt.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ export interface Header extends InstallHeader {
8686

8787
export type ScriptText = Record<string, string>;
8888

89-
export interface Project {
89+
export interface MakeCodeProject {
9090
header?: Header;
9191
text?: ScriptText;
9292
}
@@ -333,7 +333,7 @@ export interface EditorWorkspaceSyncResponse extends EditorMessageResponse {
333333
/*
334334
* Full list of project, required for init
335335
*/
336-
projects: Project[];
336+
projects: MakeCodeProject[];
337337
// (optional) filtering argument
338338
editor?: EditorSyncState;
339339
// (optional) controller id, used for determining what the parent controller is
@@ -345,12 +345,12 @@ export interface EditorWorkspaceSaveRequest extends EditorMessageRequest {
345345
/*
346346
* Modified project
347347
*/
348-
project: Project;
348+
project: MakeCodeProject;
349349
}
350350

351351
export interface ImportProjectOptions {
352352
// project to load
353-
project: Project;
353+
project: MakeCodeProject;
354354
// (optional) filtering argument
355355
filters?: ProjectFilters;
356356
searchBar?: boolean;
@@ -364,7 +364,7 @@ export interface EditorMessageImportProjectRequest
364364

365365
export interface ImportExternalProjectOptions {
366366
// project to load
367-
project: Project;
367+
project: MakeCodeProject;
368368
}
369369

370370
export interface EditorMessageImportExternalProjectRequest

0 commit comments

Comments
 (0)