refac

Author: taylorwilsdon

gdocs/docs_helpers.py

@@ -1606,8 +1606,8 @@ def create_update_table_column_properties_request(
     width: float = None,
     width_type: str = None,
     tab_id: Optional[str] = None,
-) -> Dict[str, Any]:
-    """Build an updateTableColumnProperties request."""
+) -> Optional[Dict[str, Any]]:
+    """Build an updateTableColumnProperties request. Returns None if no properties set."""
     location: Dict[str, Any] = {"index": table_start_index}
     if tab_id:
         location["tabId"] = tab_id
@@ -1623,6 +1623,9 @@ def create_update_table_column_properties_request(
         properties["widthType"] = width_type
         fields.append("widthType")
 
+    if not fields:
+        return None
+
     return {
         "updateTableColumnProperties": {
             "tableStartLocation": location,

gdocs/managers/batch_operation_manager.py

@@ -801,6 +801,12 @@ def _build_operation_request(
                 width_type=op.get("width_type"),
                 tab_id=tab_id,
             )
+
+            if not request:
+                raise ValueError(
+                    "update_table_column_properties requires at least one of: width, width_type"
+                )
+
             description = (
                 f"update column properties for columns {op['column_indices']} "
                 f"in table at {op['table_start_index']}"

gdocs/managers/validation_manager.py

@@ -822,7 +822,9 @@ def validate_table_cell_style_params(
             (padding_right, "padding_right"),
         ):
             if padding_value is not None:
-                if not isinstance(padding_value, (int, float)):
+                if isinstance(padding_value, bool) or not isinstance(
+                    padding_value, (int, float)
+                ):
                     return (
                         False,
                         f"{padding_name} must be a number, got {type(padding_value).__name__}",

tests/gdocs/test_table_cell_style.py

@@ -170,6 +170,11 @@ def test_zero_padding_is_valid(self, vm):
         is_valid, msg = vm.validate_table_cell_style_params(padding_top=0.0)
         assert is_valid, msg
 
+    def test_bool_padding_rejected(self, vm):
+        is_valid, msg = vm.validate_table_cell_style_params(padding_top=True)
+        assert not is_valid
+        assert "must be a number" in msg
+
     def test_no_style_params_rejected(self, vm):
         is_valid, msg = vm.validate_table_cell_style_params()
         assert not is_valid

tests/gdocs/test_table_column_properties.py

@@ -72,6 +72,7 @@ def test_no_tab_id_excluded(self):
         result = create_update_table_column_properties_request(
             table_start_index=10,
             column_indices=[0],
+            width=60.0,
         )
         location = result["updateTableColumnProperties"]["tableStartLocation"]
         assert "tabId" not in location
@@ -89,13 +90,12 @@ def test_structure_keys(self):
         assert "tableColumnProperties" in inner
         assert "fields" in inner
 
-    def test_empty_fields_when_no_properties(self):
+    def test_returns_none_when_no_properties(self):
         result = create_update_table_column_properties_request(
             table_start_index=10,
             column_indices=[0],
         )
-        inner = result["updateTableColumnProperties"]
-        assert inner["fields"] == ""
+        assert result is None
 
 
 class TestValidateOperation:
@@ -173,6 +173,17 @@ async def test_end_to_end_update_table_column_properties(self, manager):
         assert success
         assert meta["operations_count"] == 1
 
+    def test_no_properties_raises_value_error(self, manager):
+        with pytest.raises(ValueError, match="at least one of"):
+            manager._build_operation_request(
+                {
+                    "type": "update_table_column_properties",
+                    "table_start_index": 10,
+                    "column_indices": [0],
+                },
+                "update_table_column_properties",
+            )
+
     def test_supported_operations_include_update_table_column_properties(self, manager):
         supported = manager.get_supported_operations()["supported_operations"]
         assert "update_table_column_properties" in supported