Skip to content

Commit d22d7d1

Browse files
committed
Fix issue with multi-value query variables. Close #84
1 parent 159543a commit d22d7d1

File tree

3 files changed

+21
-1
lines changed

3 files changed

+21
-1
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
### ⭐ Added
66
- Add `$__timeTzFilter(column_name)` macro.
77

8+
### 🐞 Bug Fixes
9+
- Fix issue with multi-value query variables.
10+
811
### 🔨 Changed
912
- Upgrade grafana-plugin-sdk-go to version v0.246.0.
1013
- Upgrade gosnowflake to version v1.11.1.

README.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,16 @@ For Time series query:
102102

103103
![Query editor](img/query.png)
104104

105+
##### Query Variables
106+
107+
You can use query variable in your query.<br/>
108+
Query variables are used to filter the data displayed in the dashboard.
109+
110+
Sample query variable usage:
111+
```sql
112+
SELECT column FROM table WHERE column in ($variable)
113+
```
114+
105115
##### Layout of a query
106116

107117
*Simple query*

src/datasource.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,15 @@ export class DataSource extends DataSourceWithBackend<SnowflakeQuery, SnowflakeO
1010
this.annotations = {};
1111
}
1212

13+
private format(value: any) {
14+
if (Array.isArray(value)) {
15+
return `'${value.join("','")}'`;
16+
}
17+
return value;
18+
}
19+
1320
applyTemplateVariables(query: SnowflakeQuery, scopedVars: ScopedVars): SnowflakeQuery {
14-
query.queryText = getTemplateSrv().replace(query.queryText, scopedVars);
21+
query.queryText = getTemplateSrv().replace(query.queryText, scopedVars, this.format);
1522
return query;
1623
}
1724

0 commit comments

Comments
 (0)