fix: Resolve the issue of reusing closed connections. (#96)

devnied · web-flow · commit 7f933cfaf070 · 2024-11-22T12:38:49.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## 1.8.1
 
+### 🐞 Bug Fixes
+- Resolve the issue of reusing closed connections.
+
 ### 🔨 Changed
 - Upgrade grafana-plugin-sdk-go to version v0.258.0.
 - Upgrade gosnowflake to version v1.12.0.
diff --git a/pkg/check_health.go b/pkg/check_health.go
@@ -20,7 +20,7 @@ func (td *SnowflakeDatasource) CheckHealth(ctx context.Context, req *backend.Che
 		return result, nil
 	}
 	// Use the existing db field instead of opening a new connection
-	if td.db == nil {
+	if td.db == nil || td.db.Ping() != nil {
 		var err error
 		td.db, err = sql.Open("snowflake", connectionString)
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ func (td SnowflakeDatasource) CheckHealth(ctx context.Context, req backend.Che`
`20`	`20`	`return result, nil`
`21`	`21`	`}`
`22`	`22`	`// Use the existing db field instead of opening a new connection`
`23`		`- if td.db == nil {`
	`23`	`+ if td.db == nil \|\| td.db.Ping() != nil {`
`24`	`24`	`var err error`
`25`	`25`	`td.db, err = sql.Open("snowflake", connectionString)`
`26`	`26`	`if err != nil {`