Skip to content

Commit 82910c6

Browse files
committed
🐞 fix initializing with jQuery bridget
add min.js
1 parent 222e655 commit 82910c6

File tree

5 files changed

+89
-5
lines changed

5 files changed

+89
-5
lines changed

β€Ždist/infinite-scroll.pkgd.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -780,8 +780,9 @@ utils.htmlInit( InfiniteScroll, 'infinite-scroll' );
780780
// add noop _init method for jQuery Bridget. #768
781781
proto._init = function() {};
782782

783-
if ( jQuery && jQuery.bridget ) {
784-
jQuery.bridget( 'infiniteScroll', InfiniteScroll );
783+
let { jQueryBridget } = window;
784+
if ( jQuery && jQueryBridget ) {
785+
jQueryBridget( 'infiniteScroll', InfiniteScroll, jQuery );
785786
}
786787

787788
// -------------------------- -------------------------- //

β€Ždist/infinite-scroll.pkgd.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€Žjs/core.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -359,8 +359,9 @@ utils.htmlInit( InfiniteScroll, 'infinite-scroll' );
359359
// add noop _init method for jQuery Bridget. #768
360360
proto._init = function() {};
361361

362-
if ( jQuery && jQuery.bridget ) {
363-
jQuery.bridget( 'infiniteScroll', InfiniteScroll );
362+
let { jQueryBridget } = window;
363+
if ( jQuery && jQueryBridget ) {
364+
jQueryBridget( 'infiniteScroll', InfiniteScroll, jQuery );
364365
}
365366

366367
// -------------------------- -------------------------- //

β€Žtest/dist-jquery.js

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
const test = require('ava');
2+
const puppeteer = require('puppeteer');
3+
const getServer = require('./_get-server.js');
4+
5+
const port = 9011;
6+
let server, browser, page;
7+
8+
test.before( async function() {
9+
server = getServer();
10+
server.listen( port );
11+
browser = await puppeteer.launch();
12+
page = await browser.newPage();
13+
await page.goto(`http://localhost:${port}/test/html/dist-jquery.html`);
14+
} );
15+
16+
test.after( async function() {
17+
page.close();
18+
await browser.close();
19+
server.close();
20+
} );
21+
22+
// ------ tests ------ //
23+
24+
test( 'dist jQuery', async( t ) => {
25+
26+
let assertions = await page.evaluate( function() {
27+
const { jQuery } = window;
28+
let $container = document.querySelector('.container');
29+
$container = jQuery('.container').infiniteScroll({
30+
path: 'page/{{#}}.html',
31+
append: '.post',
32+
});
33+
34+
let infScroll = $container.data('infinite-scroll');
35+
36+
return $container.infiniteScroll('loadNextPage')
37+
.then( function( load ) {
38+
let { response, body, items } = load;
39+
serialT.true( response instanceof Response );
40+
serialT.true( response.ok );
41+
serialT.is( response.status, 200 );
42+
serialT.true( body instanceof HTMLDocument );
43+
serialT.true( items instanceof NodeList );
44+
serialT.is( items.length, 2 );
45+
serialT.true( items[0] == $container[0].children[1] );
46+
serialT.true( items[1] == $container[0].children[2] );
47+
serialT.is( infScroll.pageIndex, 2 );
48+
serialT.is( infScroll.loadCount, 1 );
49+
} )
50+
.then( () => serialT.assertions );
51+
} );
52+
53+
assertions.forEach( ({ method, args }) => t[ method ]( ...args ) );
54+
} );

β€Žtest/html/dist-jquery.html

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
<!doctype html>
2+
<html lang="en">
3+
<head>
4+
<meta charset="utf-8" />
5+
<meta name="viewport" content="width=device-width" />
6+
7+
<title>Infinite Scroll test - dist jQuery</title>
8+
9+
<link rel="stylesheet" href="test.css" />
10+
11+
<!-- dependencies -->
12+
<script src="../../node_modules/jquery/dist/jquery.js"></script>
13+
<script src="../../dist/infinite-scroll.pkgd.min.js"></script>
14+
<!-- test helper -->
15+
<script src="_serial-t.js"></script>
16+
17+
</head>
18+
<body>
19+
20+
<h1>Infinite Scroll test - dist jQuery</h1>
21+
22+
<div class="container">
23+
<div class="post">page 1, post 1</div>
24+
</div>
25+
<p><a class="next-link" href="page/2.html">Next</a></p>
26+
27+
</body>
28+
</html>

0 commit comments

Comments
Β (0)